This is hard to explain via text, so I'm including a video.

To reproduce:

  1. Load Olivero at about 400px width.
  2. Open up the menu, and then open a submenu.
  3. Sometimes the submenu will overflow the bottom, so start swiping up... but when you start the swipe, make sure that you start swiping somewhere other than on any submenu items or submenu parents.
  4. Note that the submenu will now close, even though you intended for the page to scroll.
CommentFileSizeAuthor
#3 after patch.mov1.99 MBgauravvvv
#3 before patch.mov1.95 MBgauravvvv
#2 3211897.patch1.17 KBmherchel
swipe-up.mp418.04 MBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new 3211897.patch1.17 KB

Patch attached. Tugboat URL: https://3211897-swipe-up-mobile-zchspqeorqu5kodychnfguv35qnhujjz.tugboat...

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before patch.mov1.95 MB
new after patch.mov1.99 MB

Now I am able to scroll in live preview https://3211897-swipe-up-mobile-zchspqeorqu5kodychnfguv35qnhujjz.tugboat... when the dropdown is opened.
I have added before and after-patch screen recordings for the same.

Marking as RTBC

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Needs tests

Can we add test coverage for this?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

I honestly don't know if we can. I don't see that Nightwatch supports Touch Events https://nightwatchjs.org/api/commands/#elementinteraction-headline

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community

Moving back to RTBC (per @lauriii slack message). Nightwatch apparently doesn't support touch events.

  • lauriii committed 9d05a12 on 9.3.x 
    Issue #3211897 by mherchel, Gauravmahlawat: Olivero: On mobile width,...

  • lauriii committed 6abc653 on 9.2.x 
    Issue #3211897 by mherchel, Gauravmahlawat: Olivero: On mobile width,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs tests

There seems to have been an open issue to provide touch support in Nightwatch https://github.com/nightwatchjs/nightwatch/issues/826 but it was never resolved.

Committed 9d05a12 and pushed to 9.3.x and 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.