Regressions with lightbox dimensions

The fix here #3210344: Broken CSS background and responsive image styles with aspect ratio Fluid help fix the issue specific for responsive image integration as lightbox triggers with aspect ratio Fluid.

But apparently still broken for regular images as lightbox triggers. Hence why the revert is still needed for regular images, as well.

Let's get the ball rolling. We need a new hotfix release for the latest covered issues and regressions.

Thank you.

I was too quick as it seemed :)

Unfortunately I cannot reproduce your latest issue, yet.

Please clarify:

• Cache cleared?
• Is it responsive image, or plain image? If responsive image, tried applying #3210344: Broken CSS background and responsive image styles with aspect ratio Fluid as well?

I couldn't reproduce it, yet.

We need to be on the same page. Please screenshot your Blazy or Slick formatter form. Thanks.

Please also reply to my 2 questions at #9? It is essential to narrow down the problem.

Thank you.

Weird they are still stretched.

The only that pops:
https://www.drupal.org/files/issues/2021-05-03/image_style_p009_media_fu...

Try removing "Automatically correct orientation". Just scale.

I never use that effect, is it image_effects.module?

If still an issue, you must apply the mentioned patch or use DEV version just to be sure.

We need to be on the same latest DEV.

The reason is that other patch contains common fixes.

You are right. I couldn't reproduce it till I add image style with scale.

The other patch here #3210344: Broken CSS background and responsive image styles with aspect ratio Fluid has fixed the Responsive part, but apparently broke Image style calculations due to being cached. Quoted my own observations:
https://www.drupal.org/project/blazy/issues/3210344#comment-14073305

> It used to work without cache, now suddenly broken. I think something else broke it.

While that cache fixed the Responsive image styles, it apparently broke regular images specific to scale.

Immediate workarounds for now:
use crop or original sizes, not scale.

Setting this to Need work here since it affects regular images.

This is the offending line:
https://git.drupalcode.org/project/blazy/commit/69865d5#6ad561ccf84b58d6...

We can only cache this for crop or responsive image, not scale.

The reason for the cache in that issue was due to this method being called twice at Responsive image:
https://www.drupal.org/project/blazy/issues/3210344#comment-14073305
> Basically the underlying problem now is that BlazyUtil::transformDimensions is called multiple times causing the previously set values overridden by the following values which are similar.

Tracking "I think something else broke it." might take time.
We'll try to revert the cache, or refine it with another check.

Feel free to share your solutions or findings. Thanks.

Looks like #15 already gave the clue:
> This line might need more unique key:
+ $key = hash('md2', $style->id());

Adding more uniqueness by uri appears to fix the issue here:

public static function transformDimensions($style, array $data, $initial = FALSE) {
    $uri = $initial ? '_uri' : 'uri';
    $key = hash('md2', ($style->id() . $data[$uri]));

    if (!isset(static::$styleId[$key])) {

Added the uniqueness to the key.

We can always optimize this later for the crop or Responsive image like already did at the container level, but we should avoid premature optimization to avoid headaches for now.

Let me know if this fixes it at your end? Thanks.

Committed. Thank you for contribution.