Convert the README.txt file to a markdown file so that it can work better in GitLab.

Note: the file still needs to be human-readable, so keep the lines to <80 characters if possible.

CommentFileSizeAuthor
#12 metatag-n3210889-12.patch15.77 KBdamienmckenna
#12 metatag-n3210889-12.interdiff.txt27.1 KBdamienmckenna
#10 interdiff_5-10.txt19.08 KBimmaculatexavier
#10 3210889-10.patch260 bytesimmaculatexavier
#5 3210889-5.patch18.93 KBimmaculatexavier
#3 3210889-3.patch0 bytesimmaculatexavier

Issue fork metatag-3210889

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

Pracheth made their first commit to this issue’s fork.

immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review
StatusFileSize
new 3210889-3.patch0 bytes

Attached is a md file patch that adheres to Drupal standards.

Pracheth opened merge request !63

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 3210889-5.patch18.93 KB

Unfortunately #3 was an empty patch!
Attached is a md file patch that adheres to Drupal standards.

dineshreddymathuku’s picture

dineshreddymathuku commented

Hi #2 and #3 looks good for me

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

This needs work to change the links to Markdown format. The first line should also be a single # symbol.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The merge request was built against the wrong branch and didn't contain anything besides the file rename, so I closed it.

DamienMcKenna closed merge request !63

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
StatusFileSize
new 3210889-10.patch260 bytes
new interdiff_5-10.txt19.08 KB

Attached patch in accordance to #7

dineshreddymathuku opened merge request !64

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3307363: Plan for Metatag 7.x-1.31
StatusFileSize
new metatag-n3210889-12.interdiff.txt27.1 KB
new metatag-n3210889-12.patch15.77 KB

Patch #10 deletes the file that doesn't exist, maybe it was done against the wrong branch?

MR 64 was built against the wrong branch (8.x-1.x), so I updated it to point to the correct branch (7.x-1.x).

The file broke some of the item lists, the code snippets didn't use the Markdown format very well and the references needed to be moved inline. This patch improves upon MR 64.

DamienMcKenna closed merge request !64

  • DamienMcKenna committed a7587f1 on 7.x-1.x 
    Issue #3210889 by immaculatexavier, Pracheth, DamienMcKenna,...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.