Closed (fixed)
Project:
Drupal core
Version:
9.3.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Apr 2021 at 15:41 UTC
Updated:
29 Mar 2022 at 12:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mherchelComment #3
mherchelComment #4
KondratievaS commentedI made some tests and noticed following bugs:
1. https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/ -> button is displaced
2. https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/form/example... ->
2.1 numbers are not centered
2.2 unexpected lines after adding field
3. https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/form/session..., https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/table -> i think table should have own horizontal scroll
4. https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/table -> header of table is not sticky
https://drive.google.com/file/d/1tq8OvYJ5jP5Jk_XfKob5CEn7ukDXEoh5/view?u...
5. https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/dialog -> dialogs are too big
Comment #5
mherchelThanks for the review @KondratievaS!
Addressing some the bugs
1) pager buttons - It's a feature not a bug :) The pager buttons will wrap when the viewport becomes too narrow
2.1) Webform radios not centered - This should be solved by setting the
visually-hiddenclass on the label, which needs to be done in the webform module2.2) This does look like a bug.
3) I'm not worried about horizontal scrolling caused by table layouts (this is in the document)
4) I'm not worried about table header sticky interactions. That's outside the scope of the theme. (the table header page isn't slated to be reviewed in the document)
5) I'm not worried about dialog sizes. This is set by jQueryUI and is external to the theme.
Is there a video showing the walkthrough?
Comment #6
mherchelPerformed video of walkthrough as I don't see one in comment #4:
https://www.youtube.com/watch?v=Vaf28brWYvs
Comment #7
proeung@mherchel Thanks for putting together a video walkthrough of the Samsung Internet mobile browser testing! Everything looks good, however, I'm not seeing bug 2.2 that @KondratievaS mentioned in comment #4 in your walkthrough.
Do we have an issue already created for the unexpected lines when a form field has been added? If so, we can use that to track the bug and close out this testing issue, since every else looks to be working fine?
Comment #9
mherchelNot sure if this is something that we changed, or Samsung Internet changed, but the bug in 2.2 is now not occurring (see screenshot). Marking this as fixed per #7.