In this screenshot:

https://www.drupal.org/files/styles/grid-3-2x/public/project-images/mail...

We can see an error message of "Login by username has been disabled, please use email address instead."

Per the Drupal interface text guidelines, however:

https://www.drupal.org/docs/develop/user-interface-standards/interface-text

We should not use the word "please".

I suggest we change this to "Login by username has been disabled. Use your email address instead."

CommentFileSizeAuthor
#2 3210728-2.patch577 byteslarisse

Comments

Morbus Iff created an issue. See original summary.

larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3210728-2.patch577 bytes

Hi! I create a patch to change the error message!

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Needs review » Fixed

Fixed and releases a new version: https://www.drupal.org/project/mail_login/releases/8.x-2.5

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Fixed » Closed (fixed)
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Closed (fixed) » Fixed
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Fixed » Closed (fixed)