Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When looking at this screenshot:
https://www.drupal.org/files/styles/grid-3-2x/public/project-images/mail...
We can see that "login by email address only" has been set. We also see that the label and description has been changed. However, this now creates a problem with the password field's #description, which still mentions "username". It should instead say "email address". We should allow the password #description to be changed via the mail_login config options too.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | after_patch.png | 16.97 KB | larisse |
| #3 | 3210727-3.patch | 2.45 KB | mohit.bansal623 |
Issue fork mail_login-3210727
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3210727-allow-resetting-of
changes, plain diff MR !1
Comments
Comment #2
jwilson3+1 Pretty inconsistent. I also dont like how if you allow username and email, the default suggested text for the field label is "Login by username/email address" but on the password reset form Drupal's default value for what is effectively the same field label is "Username or email address" which seems more clear.
It's also annoying that the description field for the login field is required. It should be okay to leave this empty.
For this reason I decided to go with login_onlyemail module which affects the password reset form as well, and instead of altering help strings via a UI, just implement a hook_form_alter in a custom module.
Comment #3
mohit.bansal623 commentedAdded the field for overriding password description when only login by email address is allowed.
Please review.
Comment #5
larisse commentedThe patch #3 works to me. Removed the description in password field when "login by email address" only is setted.
But, when I have the module install, but "login by email address only" is desabled, the description in password field is removed too. I think that description need to remove only if "login by email address only" is enabled, or no?
Comment #6
larisse commentedOh, sorry! I see that is cache problem. The patch #3 only removed the description in password field when "login by email address" only is enabled.
Changing to RTBC :)
Comment #7
mqannehFixed and releases a new version: https://www.drupal.org/project/mail_login/releases/8.x-2.5
Comment #8
mqanneh