Problem/Motivation

Notice thrown when on PHP 7.4

Deprecated: Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` in sites/all/modules/ms_core/ms_core.forms.inc on line 1425

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-3210551-2-5.txt1.58 KBfenstrat
#5 3210551-5.patch2.31 KBfenstrat
#2 3210551-2.patch681 bytesspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3210551-2.patch681 bytes
tonka67’s picture

tonka67 commented

Patch applies clean and appears to have resolved the issue. Thanks!

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Reviewed & tested by the community

Looks like the correct approach. #2 fixes static analysis:

The left-associativity of the ternary operator has been deprecated in PHP 7.4 and removed in PHP 8.0. Multiple consecutive ternaries detected. Use parenthesis to clarify the order in which the operations should be executed

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3210551-5.patch2.31 KB
new interdiff-3210551-2-5.txt1.58 KB

Actually a couple more nested ternaries needed adjusting. These things are a nightmare.