On a fresh page load, the .sticky-header-toggle button has a aria-checked value of "null". It should be set to false.

Steps to reproduce

  1. Fresh page load (incognito or clear your browser's cache)
  2. Load up the site and inspect.

CommentFileSizeAuthor
#3 Screenshot 2021-04-23 at 08.16.28.png171.61 KBgauravvvv
#2 3210329-test-only-FAIL.patch726 bytesmherchel
#2 3210329-2.patch2.1 KBmherchel
Log_in___Olivero.png174.19 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new 3210329-2.patch2.1 KB
new 3210329-test-only-FAIL.patch726 bytes

Patch (incl test) attached!

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 2021-04-23 at 08.16.28.png171.61 KB

Patch #2, fixes the issue. Now on the fresh page load, we're getting aria-checked="false".

Attaching SS for ref.

Moving to RTBC.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

  • lauriii committed 03b0c2b on 9.2.x 
    Issue #3210329 by mherchel, Gauravmahlawat: Olivero: Invalid aria...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 03b0c2b and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.