Followup from #3200370: Fix Olivero's drop-button style to conform with new form styles.

The focus style on the dropbutton toggle button is not properly aligned with the focus style of the link next to it.

Adding a top:1px on the button fixes it, but I'd like to figure out the root cause before just addressing the symptom

CommentFileSizeAuthor
#8 Screenshot_8_18_21__9_07_AM.png48.32 KBmherchel
#6 Screen Shot 2021-05-06 at 1.20.46 PM.png22.52 KBkiran.kadam911
#5 After-patch.png8.37 KBsakthivel m
#5 Before-patch.png8.97 KBsakthivel m
#5 3209532.5.patch1.37 KBsakthivel m
#4 Screenshot 2021-05-04 at 6.56.26 PM.png67.58 KBbhumikavarshney
#2 Screenshot from 2021-04-27 17-57-44.png4.41 KBanjali rathod
Screen Shot 2021-04-19 at 16.41.50.png14.39 KBmherchel

Comments

mherchel created an issue. See original summary.

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
StatusFileSize
new Screenshot from 2021-04-27 17-57-44.png4.41 KB

Does the issue still exist?

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new Screenshot 2021-05-04 at 6.56.26 PM.png67.58 KB

Hi @Anjali Rathod,
I don't think so this issue still appears as per your Screenshot.
Attaching the same of the same content.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3209532.5.patch1.37 KB
new Before-patch.png8.97 KB
new After-patch.png8.37 KB

#5 Please review the patch

kiran.kadam911’s picture

kiran.kadam911
he/him
Location Mumbai, India 🇮🇳
commented
StatusFileSize
new Screen Shot 2021-05-06 at 1.20.46 PM.png22.52 KB

@Sakthivel M We can't set outline none because there is some purpose of it mainly for accessibility.

@mherchel I tried by applying patch https://www.drupal.org/project/drupal/issues/3200370#comment-14069823 9.2.x here which applied successfully and after patch looks like there is no issue with the focus style Dropdown toggle button and the focus style of the link next to it.

SS for reference:

Please let us know your opinion like we are reviewing correctly or no to go-head.

Thanks!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Postponed

Going to postpone this. This is going to be a followup from #3200370: Fix Olivero's drop-button style to conform with new form styles and shouldn't be worked on quite yet. It may be fixed in the patch that gets committed.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Postponed » Closed (cannot reproduce)
StatusFileSize
new Screenshot_8_18_21__9_07_AM.png48.32 KB

Closing this out. I believe this was fixed in #3200370: Fix Olivero's drop-button style to conform with new form styles. Either way, it's not an issue now.