Fix spelling for 29 migrate translation related words

Addressed #7.

The cspell:ignore prefix needs to appear at the start of each line after wrapping.

1. +++ b/core/modules/field/src/Plugin/migrate/source/d6/FieldOptionTranslation.php
   @@ -2,6 +2,8 @@
   +// cspell:ignore objectid objectindex
   

   I wonder if these should just remain in the dictionary, as we have to exclude them a lot of times.

2. +++ b/core/modules/field/tests/src/Kernel/Plugin/migrate/source/d6/FieldOptionTranslationTest.php
   @@ -4,7 +4,7 @@
   +// cspell:ignore optionwidgets selectlist objectid objectindex
   

   So far we have conventionally put ignore lists in alphabetical order.

3. +++ b/core/modules/migrate/src/Event/MigrateEvents.php
   @@ -167,10 +169,10 @@ final class MigrateEvents {
   -   * logged by the idmap. The event listener method
   +   * logged by the ID map. The event listener method
       * receives a \Drupal\migrate\Event\MigrateIdMapMessageEvent instance.
   

   Wrapping here is a bit weird, maybe we should fix while we are here?

4. +++ b/core/modules/migrate/src/Event/MigrateEvents.php
   @@ -179,6 +181,6 @@ final class MigrateEvents {
   -  const IDMAP_MESSAGE = 'migrate.idmap_message';
   +  const IDMAP_MESSAGE = 'migrate.id_map_message';
   

   Is this safe to change? Can we assume users will always refer to the constant and not the actual string?

Also regarding

There are two files where 'Highwater' is ignored to allow for \Drupal\migrate\Plugin\migrate\source\SourcePluginBase::aboveHighwater.

Can we be sneaky here and rename the method to ::aboveHighWater? It is backward compatible as method names are not case sensitive in PHP.

Can I be the grumpy old man that points out that we're putting a lot of effort in, but we don't (as far as I'm aware) have something to prevent the next user that comes along, to simply re-add words like nodereference?

With Coding Standards we make sure we have sniffs in Coder in place, is there something similar for cspell? Would this at all be possible?

</grumpyOldManMode>

@quietone: Thanks for clearing that up :)

I propose an alternative method of dealing with a number of these misspelled words that begin with "n" due to them being prefixed with "i18n" in #3210694: Ignore i18n-prefixed words in spellcheck

#22 Patch applied successfully
After patch spelling related issue has been fixed
Thanks for the patch

error: patch failed: core/misc/cspell/dictionary.txt:249
I'm sorry I found this one too late to RTBC, looks like it needs Yet Another Reroll.

LGTM

Rerolled the patch in #25, thanks!

+++ b/core/modules/node/src/EventSubscriber/NodeTranslationMigrateSubscriber.php
@@ -11,7 +11,7 @@
+ * Creates a key value collection for migrated node translation re-directions.

I am not sure this is correct. While "redirections" isn't a dictionary word I don't think replacing it with just "re-directions" helps - to me this is now harder to read than before.

We could either keep "redirections" in the dictionary or replace this with just "redirects" or something like "mappings" which makes sense in this context.

For a 10.1 patch

Also to address feedback in #29.

Please try to address the feedback before rerolling.

Had trouble with the interdiff so uploaded a diff.
Addressed #29 by using "mapping" as I agree that made more sense.
Rerolled for 10.1

Following #3210694: Ignore i18n-prefixed words in spellcheck we should not need cspell:ignore for nblocks, nprofile, nstrings, ntaxonomy, etc?

Removed those cspell lines

Still several instances of ncck, nmenu, nstrings, ntaxonomy that should be able to be removed.

Thanks removed more of those instances.

Seems to be a random failure.

Rerolled

Rerolled

Removed mlid and plid from IS
Removed chien chiens
And yes tnid seems to be specific to D7

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

#46 was the wrong patch.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

error: patch failed: core/misc/cspell/dictionary.txt:974
error: core/misc/cspell/dictionary.txt: patch does not apply

Was an issue with word "vous"

Attempted to address #51

+++ b/core/modules/content_translation/migrations/d6_menu_links_translation.yml
@@ -1,3 +1,4 @@
+# cspell:ignore mlid

If we're keeping mlid in the dictionary we do not need any ignore lines for it. Same with plid.

Not sure what we should do about tnid - this was a Drupalism in D6/D7 ("translated node ID") but it is not used in D8+.

Addressed #54

Removed
-chien
-chiens
From the issue summary.

Searching the rest I see they have been removed successfully from the dictionary.txt file.

1. +++ b/core/misc/cspell/dictionary.txt
   @@ -980,7 +958,6 @@ rebuilder
   -redirections
   

   I know I mentioned this before but I'm not convinced that "redirections" should be disallowed; we use "redirection" as a noun so pluralising it is OK? I don't think "re-directions" is better; it passes the spellcheck but doesn't have the same meaning, to me.

2. +++ b/core/modules/field/src/Plugin/migrate/source/d7/FieldInstance.php
   @@ -5,6 +5,7 @@
   +// cspell:ignore localizable
    /**
   

   Missing blank line between cspell comment and docblock.

3. +++ b/core/modules/migrate/tests/src/Kernel/Plugin/MigrationProvidersExistTest.php
   @@ -7,8 +7,8 @@
   +// cspell:ignore entityreference filefield imagefield nodereference
   +// cspell:ignore optionwidgets userreference
    /**
   

   Same.

I would have fixed the latter two on commit but I'm still not sure about the first.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Addressed 2 and 3 points from #58 and raised an MR with the changes.

Moving back to NW as Point 1 from #58 still needs to addressed.

Thanks @quietone for cleaning that up.

Reroll looks good. Hopefully can commit this one soon.

Thanks @quietone and @smustgrave! Committed 418ce00 and pushed to 11.x. Thanks!