A few things I have noticed looking at this code. This module does not utilize hook_schema to create tables. Nor do the queries use {geouser} (the table prefix) notation.

CommentFileSizeAuthor
#3 geouser_install_schema_fixed.patch2.45 KBfrankcarey
#1 geouser_install_schema.patch2.35 KBfrankcarey

Comments

frankcarey’s picture

frankcarey commented
StatusFileSize
new geouser_install_schema.patch2.35 KB

Here is a patch for the geouser.install file. It pretty much replaces the entire file...

What it does:
- replaces the table creation code with an implementation of hook_schema
- adds the uninstall_schema hook to remove the db if the module is uninstalled
- adds an update to add the new 'region' field added somwhere btw 1.4 and 1.7 beta

frankcarey’s picture

frankcarey commented
Status: Active » Needs review

changing the status (surprised it's not automatic)

frankcarey’s picture

frankcarey commented
StatusFileSize
new geouser_install_schema_fixed.patch2.45 KB

Old patch had a missing return statement for the schema, this one fixes that.

zidong.c’s picture

zidong.c commented
Status: Needs review » Fixed

HI,
I'm the author of geouser module, thanks for helping me to find the advantage to implementing schema api instead of using sql to create a database.

I have already apply this patch in the latest release.

Thanks again.
Zidong

frankcarey’s picture

frankcarey commented

Also, please commit this other patch so that the module will work for those who use table prefixes (i.e. drupal_geouser instead of geouser)

http://drupal.org/node/353952

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.