Problem/Motivation

Some "not-totally Code Standard-proof code" crept in lately.

Proposed resolution

Do a little spring cleaning.

Issue fork inline_entity_form-3208826

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !22

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review

geek-merlin made their first commit to this issue’s fork.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Fixed

Thanks! All green and all cleanups make sense to me.
We have some typing changes in the signature, but in tests we have no BC restrictions.

As you may have seen, some of the tests i recently added have new helper methods, that i added but did not yet consolidate with the helper methods in base. Also after that coding sprint, i thought about putting all that methods in a trait for clarity, but just a thought.

Merged, thanks a lot!

spokje’s picture

spokje
Primary language Dutch
commented

I like it, especially the trait bit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.