Agenda items

Standing items

  • Who is here
  • Any other suggested topics
  • Wins / Thanks / Blockers
  • Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
  • The bug I would most like to see fixed
  • Update on target items from last meeting
  • What should be the initiative focus for the next 2 weeks?

Statistics

Statistics graph

New Items

ToDos

Everyone View your list of open bugs you created. Edit this URI and substitute your username. https://www.drupal.org/project/issues/search/drupal?submitted=larowlan&p... [331 issues]…].&version%5B%5D=any_9.&version%5B%5D=any_8.&issue_tags_op=%3D
@quieteone Announce availability for assisting with reviews.

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

Kunal Kapoor hi kunalkapoor , From India D.o --> kunalkapoor (edited)
ambermatz Hi! I’m co-maintainer of Help Topics. :wave: (I’m in Portland, OR USA) (edited)
mohit_aghera Hi, mohit_aghera :wave:
quietone Hi, Vicki
larowlan lee, AU :flag-au:
gaurav mahlawat Hello, Gauravmahlawat :flag-in:
jibran Jibran, AU
Griffyn Heels Hola, Griff Aus :wave:
Michael (g-brodiei) Good day, Michael from Taiwan
Neslee Neslee, Goa
anmolgoyal74 Hi
lendude Len, Amsterdam
Kristen Pol (she/her) Kristen, in car in Central California, not driving myself
Spokje Frank, definitely not driving in a car in Central California, but in The Hague Netherlands
hansa11 Hansa, India :wave: (edited)
mansoor20 Hi :wave:
Guilherme Vitoriano Pereira Hi from Brazil! Always late due to timezone!
Paulo Henrique Cota Starling paulocs from Belo Horizonte, Brazil :flag-br:

0️⃣ .5️⃣ What's the last movie you watched and was it any good?

ambermatz Watched Thunder Force and I thought it was hilarious.
larowlan watched Hot Fuzz with my wife and daughter, loved it
quietone Good Soldier - a sad, sad story
mohit_aghera Not movie but watched a couple of episodes of Parks And Recreation , it was fun
jibran Watched Nobody,  it was good time pass.
Griffyn Heels watched sound of metal last weekend, fantastic, made me want to learn to sign
Michael (g-brodiei) Watched love and monsters  last week, fun and cheerful adventure movie to share with friends and family during the weekend.
anmolgoyal74 Hi..  it’s been a while since i watched anything..
lendude Watched The Terminal for the Nth time but this time with the whole family
Kristen Pol (she/her) Tenet, didn't like it even though Memento is in my top favorites
Spokje Bird Box Promising movie, just fell a little short for my expectations of it.
Guilherme Vitoriano Pereira Last night I watched two oscar winning short films: If anything happens I love you, and two strangers. Both are pretty good and pretty distressing in a way good films can be.
Paulo Henrique Cota Starling I watched Shutter Island. What an amazing film!

0️⃣ .7️⃣5️⃣ If you joined during Drupalcon and this is your first meeting, tell us a bit about yourself, what brings you here and what you hope to get out of the initiative

ambermatz As co-maintainer of Help Topics, we come across old core bugs on occasion. I think this initiative dovetails nicely into the work we’re doing in help topics.
ambermatz Also, I’m hoping to learn skillz in triaging and help out that way.
Kristen Pol (she/her) @ambermatz Yay! :wave:
Spokje First Meeting: YesThrough Drupalcon: Nope.I somehow encountered quietone and longwave more and more as I was doing some bugfixing and looked a bit deeper into this whole "BugSmash"-thing because of them.Liked it, so decided to try out some meetings :slightly_smiling_face:Also already met paulocs and lendude in the d.o. issue-queueu quite a few times. (Hey, it is the place where the cool people hang out after all :sunglasses:...)
larowlan Welcome both of you :wave: (and anyone who comments after this)

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

jibran Is https://drupal.slack.com/archives/C014QES6HSQ/p1591395578104700?thread_t... still relevant?
quietone An issue was triaged, closed and added to the triage meta. Then it was re-opened. Even though the issue is no longer closed the triagers should get credit. Correct?
Kristen Pol (she/her) Feedback on DrupalCon contribution event... things that went well and could have been better

2️⃣.1️⃣ Wins - what wins have you had since the last meeting in December? Share your successes!

larowlan The number of new faces here makes me feel like the DC presentation helped
mohit_aghera [#2839558]And few other issues.
larowlan I got an uninterrupted hour on the core RTBC queue last night - made some headway
Kristen Pol (she/her) Nice to see new names/faces in here like @ambermatz
ambermatz The DC presentation was really inspiring and the folks involved really helpful and kind.
Grimreaper "since the last meeting in December"???
larowlan Whoops C/P fail

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

jibran Thank you Lee for getting up so early and presenting at Drupalcon.
Guilherme Vitoriano Pereira My shoutout is for you @larowlan for the shouout for me in DrupalCon, I'm new here, trying my best to help and learn. Thanks!
Grimreaper Thanks @Nicoloye (he/him) and @larowlan for the reviews on #2359675: File field's Maximum upload size always passes validation and @Paulo Henrique Cota Starling for pushing it

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

mohit_aghera I need help from someone to review the issues that are in Needs reviewNeeds review issues link
Kristen Pol (she/her) So busy with DrupalCon related stuff that it's been hard to be in the issue queue

3️⃣ Core bug statistics - current state of open bug

larowlan 37 bugs smashed this fortnight, but 78 new ones opened
quietone Today: 2021-04-27From: 2021-04-13 to 2021-04-27Open: 84, including 25 fixedClosed: 60 Age Count 00 27 01 06 02 03 03 03 04 04 05 04 06 07 08 01 09 02 10 01 11 01 16 01 Status Countclosed (duplicate) 18closed (won't fix) 2closed (works as designed) 8closed (fixed) 23closed (outdated) 3closed (cannot reproduce) 6
quietone My counts are a bit different
larowlan that looks much nicer
larowlan how are you generating that? I'm just crudely counting bugs smashed vs new bugs
quietone Modified https://gitlab.com/Lendude/bug-smash-initiative to limit the dates. It counts D8/9 bugs not just those tagged bugsmash. And doesn't count bugs moved to D7 queue which I have done for some issues.
larowlan that sounds much more accurate than my approach
quietone It was a matter of my sanity, too often I was feeling like Sisyphus.
larowlan I was too, until I did the 12 months numbers (see the slides) and that made me feel like we were making a dint
lendude @quietone would it be an idea to shoot a merge request to my bug smash repo with your version of the script?
lendude Also might be nice to start collecting these datapoints and maybe turn them into a graph
lendude Really still looking for a good way to turn our work into something easy on the eyes
lendude Added a datapoint for today https://lendude.gitlab.io/bug-smash-initiative/
lendude If you look at the bars in the animation you can see all the bars, across the board, shrinking the last couple of datapoints. Awesome stuff (edited)
lendude And our bug debt in years has shrunk over the last year which is amazing work
lendude Merged @quietone s data gathering script to the bugsmash repo https://gitlab.com/Lendude/bug-smash-initiative/-/tree/master , thanks @quietone!

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

mohit_aghera #3184974: FileUploadResource does not release lock on validation errors#comment-13963397
Spokje Since I've got introduced to BugSmash by doing a lot of these issues: https://www.drupal.org/project/issues/search?text=&projects=Drupal+core&...…]atus%5B%5D=Open&issue_tags_op=%3D&issue_tags=Coding+standards (edited)

5️⃣ Help me - Is there anything you could use a :hand:

mohit_aghera #3122056: Do not track viewing history for unsaved entities, nor when previewing existing entities#comment-13744322 can we test this using Kernel test or we need functional test only?I tried functional test, however it seems not working due to cache or something.
jibran Upload the WIP patch and leave me a ping.
mohit_aghera Got it.
mohit_aghera #3122056: Do not track viewing history for unsaved entities, nor when previewing existing entities#comment-14073548@jibran Added a patch which is failing on local for me.
Spokje As a BugSmash Novice: Is there a documentation out there on what the general workflow is for Bugsmashers? Stuff like what to tag, how tot tag, etc? I sometimes see BugSmashers closing an issue as a Duplicate and giving credit in the non-duplicate issue to people from the duplicate issue (transfering credits). Do you need god-like powers to do this?(edited)
larowlan to transfer credit, you need to be a core maintainer (listed in maintainers.txt) but you can ping someone here to do that if you come across it
larowlan re 1) we tag anything we touch as part of work here
Spokje Thanks for that, all clear (at least for now :smiling_imp: ...)
Paulo Henrique Cota Starling @larowlan or @dww #2359675: File field's Maximum upload size always passes validation can you please tell me what is the best approach here? I thought about keep the FileItemTest.php but reduce the data provider in the class. (edited)
larowlan I think one case that tests for form error, and then a unit test case for all the scenarios

6️⃣ The DA (I think) is looking to create some Bug Smash swag, but they're looking for us to approve a logo. There's two here for consideration

mohit_aghera #3208981: A new BugSmash logo design#comment-14065005 looks interesting to me.
Griffyn Heels I like the option that @Kristen Pol (she/her) posted
quietone I wish there was some way to do this without depicting the death of a bug.
jibran My thoughts exactly.
Griffyn Heels Yeah good idea, maybe just a hammer instead?
quietone As my partner pointed out, we are fixing defects.
larowlan fwiw the phrase 'bugsmash' was borrowed from the shape up project management methodology
larowlan https://basecamp.com/shapeup/2.2-chapter-08#what-about-bugs
Kristen Pol (she/her) Totally open to other concepts. I can give him whatever ideas people have
Kristen Pol (she/her) I wonder if he could do something like Super Smash Bros
Kristen Pol (she/her) https://images.app.goo.gl/uR9okQh81nzTztz77
Kristen Pol (she/her) Drupal Smash Pros
Kristen Pol (she/her) Bug Smash Pros
Kristen Pol (she/her) But maybe that game is violent? I haven't played it
mradcliffe I made the combined banner or when I needed to choose a focal point, I focused on the human with the hammer rather than the insect. I did refer to the insect as a "creepy crawler" in some of the alt tags.

7️⃣ via Jibran: should we have leads for various tasks so there's a contact point. Eg. For example we have someone as the needs review lead, so if people want to help with reviews, they can contact that person for help/advice/places to start

larowlan And if you're interested in this, please nominate yourself
larowlan I think the leads would be:getting startedtriageneeds reviewneeds testswhat have I missed?
ambermatz Would re-rolls be a task for this group?
jibran The question is do we need this? Are we going along fine? Do you think, you don't know who to ping for help?
quietone What are the responsibilities of say the 'needs review' lead?
larowlan I'd flip it the other way
larowlan i.e. its not up to newcomers to know who to ask, its more that the leads keep an eye out for those sort of questions in this channel
quietone Perhaps the lead could encourage by announcing that they are available to asssist.
quietone I am willing to trail this, and make myself available for helping with reviews.
jibran I have shared this before that it is not 24/7 job. You just have to check once a day. Leave some comments ping someone who can help
quietone @jibran, thanks for repeating. It is not uncommon for me to have to hear things more than once to 'get it'.
jibran hehe, It was not directed to you :slightly_smiling_face: I was just pointing it for anyone interested in being lead.
Kristen Pol (she/her) I'm curious about this but not sure how it will play out... Maybe I'll watch first ;)
mohit_aghera I can do some help to folks who are new to test cases and writing those.Probably for Needs work and Needs tests  tags. (edited)

8️⃣ via quietone: An issue was triaged, closed and added to the triage meta. Then it was re-opened. Even though the issue is no longer closed the triagers should get credit. Correct?

larowlan I think we're crediting for the effort of triage, so I think it should be a credit, even if it wasn't the final outcome
pameeela well ideally they would get credit when the original issue is fixed/committed, so they don’t need it in the triage ticket, but i don’t think this is a big issue :slightly_smiling_face: (edited)
pameeela the earlier policy was to add several issues triaged, in that case you’re not relying on a single issue

9️⃣ via larowlan: homework for next fortnight's meeting view the list of open bugs you created, and see if any of them can now be closed.

larowlan this link is for my issues https://www.drupal.org/project/issues/search/drupal?submitted=larowlan&p...…].&version%5B%5D=any_9.&version%5B%5D=any_8.&issue_tags_op=%3D
larowlan edit the URI and substitute your own username
larowlan I was able to get my list down to 16 from 17 and did some triage on the oldest of the remaining 16
larowlan And with time/distance, I reckon some of those are not bugs, but tasks/feature requests, and I'll reassign as such
quietone @larowlan excellent role-modelling :smile:
larowlan allowed me to dig up these tragic dad jokes from my past #2577923: MenuLinkContent entities pointing to nodes are not deployable: LinkItem should have a "target_uuid" computed property#comment-11496899
larowlan got the list down to 12, 1 is fixed, so 11
Kristen Pol (she/her) I had none... now I feel like a slacker:)
larowlan well that means all the issues you created are fixed :excellent:
Kristen Pol (she/her) Or I never ever reported any... I'll check
Kristen Pol (she/her) I had one: https://www.drupal.org/project/issues/search/drupal?text=&assigned=&subm...

1️⃣0️⃣ late breaking issue from Kristen Pol: Feedback on DrupalCon contribution event... things that went well and could have been better

larowlan apologies again for having to drop off for a while, timing wise it didn't work out great after my session
Kristen Pol (she/her) Thanks for adding this :)
Kristen Pol (she/her) I didn't feel as helpful in the bugsmash contribution event than the d10readiness but I'm trying to recall the specifics... I did get a late start. I liked having breakout rooms

Participants:

Kunal Kapoor, ambermatz, mohit_aghera, quietone, larowlan, gaurav mahlawat, jibran, Griffyn Heels, Michael (g-brodiei), Neslee, anmolgoyal74, lendude, Kristen Pol, Spokje, hansa11, mansoor20, Guilherme Vitoriano Pereira, Paulo Henrique Cota Starling, Grimreaper, mradcliffe, pameeela

Comments

quietone created an issue. See original summary.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes

quietone credited Gauravmahlawat.

quietone credited Grimreaper.

quietone credited Kristen Pol.

quietone credited Lendude.

quietone credited Neslee Canil Pinto.

quietone credited anmolgoyal74.

quietone credited g-brodiei.

quietone credited griffynh.

quietone credited guilhermevp.

quietone credited hansa11.

quietone credited jibran.

quietone credited kuna.

quietone’s picture

quietone commented
Issue summary: View changes
kunal_kapoor’s picture

kunal_kapoor commented

@quietone My d.o is kunalkapoor i think you have added kuna. by mistake

quietone credited Spokje.

quietone credited mohit_aghera.

quietone’s picture

quietone commented
Issue summary: View changes

quietone credited larowlan.

quietone credited mansoor20.

quietone credited pameeela.

quietone credited paulocs.

quietone’s picture

quietone commented
quietone’s picture

quietone commented
Status: Active » Fixed

@kunalkapoor, thanks. There must be a size limit on that field because something like that happens every week. I should change my script that converts slack names to d.o names to handle that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone credited Amber Himes Matz.

quietone’s picture

quietone commented

I missed adding credit to this issue for Amber Himes Matz