Hi Nathaniel,

I hope you are doing well!
Sorry one more question, I was wondering is there any possibility to add fields for the image pages? Stuff like "styled google map",
I could make it for albums from content-type settings, but currently I do need a maps field for image pages (/photos/image/1#image-load)..

It would be cool if I could get it customized.

Thank you!!

CommentFileSizeAuthor
#6 photos-6.0.x-3208598-6.patch492 bytesnathaniel

Comments

kingto created an issue. See original summary.

nathaniel’s picture

nathaniel commented

If you are working on a new site I recommend using the 6.0.x version. Then you can add any fields to the image: /admin/structure/photos/fields

If you must use 8.x-4.x for some reason, then you might be able to use the https://www.drupal.org/project/file_entity it might be more work though.

kingto’s picture

kingto commented

You are too kind, thank you for your promt reply!

I've tested File_entity and tragically found it only works at /file/add/. The field is not showing when I upload or edit from a normal form.
Then I've tried to setup a brand new (drupal 8.8) website with Album Photos 6.0.x.

To my surprise, I am detered by an internal error right after the module being enabled. It keeps telling "HTTP ERROR 500" when I open, create or edit any content.
No more information is recorded by the logging module.

I'm certain that Media and Media Library are enabled.

Same error also showing when I update the module from 8.x-4.x.

/update.php/start?id=27&op=do_nojs&op=do
Internal Server Error
update # in photos_post_update_migrate_photos_image_entity_1.module
nathaniel’s picture

nathaniel commented
Status: Active » Postponed (maintainer needs more info)

Hmm interesting. Sorry for the bad experience! I wonder if we require 8.9 now, I haven't tested 8.8 in a while.

Do you have access to the error logs? I'll try to test 8.8 sometime soon to see if I can reproduce the error.

kingto’s picture

kingto commented

Never mind. I'll try another also. Much appreciated!!!

PHP Fatal error: Declaration of Drupal\photos\PhotosUpload::unzip($source, $params, $scheme = 'default') must be compatible with Drupal\photos\PhotosUploadInterface::unzip($source, array $params, $scheme = 'default') in /home/user/public_html/modules/photos/src/PhotosUpload.php on line 24

nathaniel’s picture

nathaniel commented
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new photos-6.0.x-3208598-6.patch492 bytes

Thanks! Attached a patch. When you have a moment let me know if that helps? Looks like array is missing there.

  • b4f3f11 committed on 6.0.x 
    Issue #3208598 by Nathaniel: Fix unzip declaration in PhotosUpload. Some...
nathaniel’s picture

nathaniel commented

Looks like that was the bug for php 7.0/7.1 - fixed in the dev version:
https://www.drupal.org/project/photos/releases/6.0.x-dev

kingto’s picture

kingto commented

YES! I've tested it great :)
You're the best!

nathaniel’s picture

nathaniel commented
Status: Active » Fixed

Thanks for testing/feedback!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.