Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
Olivero theme
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2021 at 00:07 UTC
Updated:
27 Apr 2021 at 09:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mherchelQuick patch attached.
Comment #3
gauravvvv commentedPretty straightforward. Patch successfully replaced variable
topLevelMenuITemtotopLevelMenuItemin core/themes/olivero/js/second-level-navigation.es6.js and core/themes/olivero/js/second-level-navigation.jsI manually tested variable
topLevelMenuITemin codebase, it has been replaced to all places.Moving to RTBC.
Comment #4
gauravvvv commentedComment #5
Madhu kumar commentedPatch #2 applied cleanly and working as expected , changing topLevelMenuITem in codebase.
Comment #7
catch@Gauravmahlawat and @Madhu kumar there's no need to post screenshots of patches applying, because DrupalCI checks this automatically and reports back if they don't. I've removed issue credit here, please see https://www.drupal.org/core/maintainers/issue-credit for how issue credit is assigned.
Committed 40a123a and pushed to 9.2.x. Thanks!
Comment #8
gauravvvv commentedHi @catch, Yeah I know that patch passed the CI so there are no chances that it can be failed in our local environment. Please re-read my comment, I mentioned that I manually verified that all the
topLevelMenuITemhas been updated in other files too.Thank you.
Comment #9
catchIf you say that you've checked other files for a similar variable name, then you don't need to provide a screenshot - we always assume people have done what they say they've done. However additionally this was obviously a file-specific typo so it was not really necessary to check other files, but more to verify that the fix in the patch itself was correct. With trivial patches like this, there is very little to review, so apart from actually writing the patch or opening the issue it's unlikely for another person to get credit (unless there turns out to be a mistake, in case it was not trivial after all).