We misnamed a variable in core/themes/olivero/js/second-level-navigation.es6.js.

topLevelMenuITem should be topLevelMenuItem. It needs to be changed in multiple places.

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Status: Active » Needs review
StatusFileSize
new3.22 KB

Quick patch attached.

gauravvvv’s picture

StatusFileSize
new297.08 KB

Pretty straightforward. Patch successfully replaced variable topLevelMenuITem to topLevelMenuItem in core/themes/olivero/js/second-level-navigation.es6.js and core/themes/olivero/js/second-level-navigation.js

I manually tested variable topLevelMenuITem in codebase, it has been replaced to all places.

Moving to RTBC.

gauravvvv’s picture

Status: Needs review » Reviewed & tested by the community
Madhu kumar’s picture

StatusFileSize
new113.3 KB

Patch #2 applied cleanly and working as expected , changing topLevelMenuITem in codebase.

  • catch committed 40a123a on 9.2.x
    Issue #3208286 by mherchel: Olivero: "topLevelMenuITem" variable should...
catch’s picture

Status: Reviewed & tested by the community » Fixed

@Gauravmahlawat and @Madhu kumar there's no need to post screenshots of patches applying, because DrupalCI checks this automatically and reports back if they don't. I've removed issue credit here, please see https://www.drupal.org/core/maintainers/issue-credit for how issue credit is assigned.

Committed 40a123a and pushed to 9.2.x. Thanks!

gauravvvv’s picture

Hi @catch, Yeah I know that patch passed the CI so there are no chances that it can be failed in our local environment. Please re-read my comment, I mentioned that I manually verified that all the topLevelMenuITem has been updated in other files too.
Thank you.

catch’s picture

If you say that you've checked other files for a similar variable name, then you don't need to provide a screenshot - we always assume people have done what they say they've done. However additionally this was obviously a file-specific typo so it was not really necessary to check other files, but more to verify that the fix in the patch itself was correct. With trivial patches like this, there is very little to review, so apart from actually writing the patch or opening the issue it's unlikely for another person to get credit (unless there turns out to be a mistake, in case it was not trivial after all).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.