filelog_install() does not seem to correctly create the .htaccess file.
drush en fileloglogs/ folder is created but without the .htaccess file.The logic in filelog_install() seems to be wrong. It will not create the .htaccess file if the folder was successfully created.
I will submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | filelog-3207566-5.patch | 1.96 KB | cburschka |
| #5 | filelog-3207566-5-testonly.patch | 1.43 KB | cburschka |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
prudloff commentedComment #4
cburschkaWow, this looks like an ancient logic error created in https://git.drupalcode.org/project/filelog/-/commit/78a84a866ad118fb489f...
The if-condition was reversed (from true on failure, causing logging to be disabled, to true on success, causing logging to be enabled), but instead of turning !A || !B into A && B, we only turned it into A || !B. Thanks for catching that!
Comment #5
cburschkaI'm expanding the functional test to check for this in the future. Here's a test-only patch.
Comment #7
cburschkaPatches look good, but the branch needs an upstream merge.
Comment #9
cburschkaPushed. Thanks for the fix!