Active
Project:
Coder
Version:
8.3.12
Component:
Coder Sniffer
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
6 Apr 2021 at 13:30 UTC
Updated:
13 Feb 2025 at 13:33 UTC
Jump to comment: Most recent
In #2721309: Fix Drupal.Commenting.FunctionComment.ParamCommentFullStop we are trying to implement "Drupal.Commenting.FunctionComment.ParamCommentFullStop", but we run in to some troubles.
Currently the sniff requires a full stop at the end of a list.
The following code:
/**
* Saves the override.
*
* @param string $id
* A menu link plugin ID.
* @param array $definition
* The definition values to override. Supported keys:
* - menu_name
* - parent
* - weight
* - expanded
* - enabled
*
* @return array
* A list of properties which got saved.
*/
public function loadOverride($id);
when sniffed comes back with:
-------------------------------------------------------------------------------------
75 | ERROR | [x] Parameter comment must end with a full stop
-------------------------------------------------------------------------------------
That goes away when we put a full stop at the end of the list like so:
/**
* Saves the override.
*
* @param string $id
* A menu link plugin ID.
* @param array $definition
* The definition values to override. Supported keys:
* - menu_name
* - parent
* - weight
* - expanded
* - enabled.
*
* @return array
* A list of properties which got saved.
*/
However, this has been deemed confusing.
Change "Drupal.Commenting.FunctionComment.ParamCommentFullStop", so that it does not check for a fullstop at the end of a list.
Comments
Comment #2
vighneshh commented