Meeting of the Bug Smash Initiative 2021-04-13 [#3206699]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Blockers
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on target items from last meeting
What should be the initiative focus for the next 2 weeks?

Statistics

Statistics graph

New Items

Add agenda items here

ToDos

TBA

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

Kristen Pol (she/her)	Kristen, Central California, doing lots of DrupalCon stuff!
mohit.aghera	Hi, Mohit :wave:
quietone	Vicki
gaurav mahlawat	Hi Gauravmahlawat
jibran	Jibran, AU
Griffyn Heels	Howdy, Griff Aus :face_with_cowboy_hat:
larowlan	lee AU
lendude	Len NL
Kunal Kapoor	kunalkapoor
anmolgoyal74	Hi
Michael (g-brodiei)	Michael Taiwan! Long time no see everyone~~
Grimreaper	Hi, Florent, France
hansa11	Hi :wave:Hansa, India
mansoor20	Hello :wave:
Paulo Henrique Cota Starling	Paulo Henrique - Belo Horizonte, :flag-br:
Guilherme Vitoriano Pereira	Guilherme - Santa Rita do Passa Quatro - Brazil
mradcliffe	Matthew here, catching up from being at DrupalCon contributions day.
dww	Tamir Rice (Black Lives Matter)

0️⃣.5️⃣ Have you been fooled by anyone this year with an April fool prank? (edited)

quietone	No. It was a day like any other.
Kristen Pol (she/her)	My husband pranked me 20+ years ago so badly that he's banned from doing anything to me :wink: I think my kids tried some very bland thing... like only staring at their dad's chest when talking to him but he caught on quickly so it was a bust... maybe next year :)
jibran	It doesn't seem to be a global thing.
Paulo Henrique Cota Starling	YES! My girlfriend told me she was pregnant... She told me it was a joke 1 minute later but it was a long minute for me.
Paulo Henrique Cota Starling	In Brazil the pranks are made on first April only...
Guilherme Vitoriano Pereira	No pranks here...
mradcliffe	A friend fooled their spouse by switching mayonnaise and yogurt containers and eating yogurt from the the mayonnaise container.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

Kristen Pol (she/her)	DrupalCon contribution plan for Thursday bugsmash
larowlan	anything anyone wants mentioned in the 'intro to bugsmash session' on Thu
larowlan	(Fri our timezone)

2️⃣.1️⃣ Wins - what wins have you had since the last meeting in March? Share your successes!

mohit.aghera	[#3171827]All got fixed. (edited)
quietone	#2414019: Use of strtoupper for URLs in MailFormatHelper.php's htmlToText() method triggers spam filters
dww	Very glad #3113798: Remove unused (and generally wrong) <tag> markup from Update module test XML fixtures is finally in (thanks, @quietone!)

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

mohit.aghera	Thanks to @jibran @quietone for helping on various issues.
quietone	@mohit.aghera_aghera for keeping issue moving (edited)
jibran	Thanks to @mohit.aghera for making me review some issues last fortnight :smile:
jibran	Thank you @quietone for making so much waves in the IQ. I'll try to keep the surf going. :)
Grimreaper	Thanks to @catch and @dww for making #2889486: "Has taxonomy term" contextual filter does not take the language value into account go forward

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues/goals

mohit.aghera	#3184974: FileUploadResource does not release lock on validation errors - I tried to write test cases for this, somehow functional tests are always passing for me. Might need some pointers around it. (edited)
Kristen Pol (she/her)	Lots of other Drupal-y things... helping a lot with d10readiness and mentoring the last few days... been doing a lot of Drupal stuff this month but only a day, I think, of bugsmash... doing ADrupalADay... hope to do more bugsmash next week... or perhaps Thursday if DrupalCon doesn't wipe me out (edited)
quietone	Getting reviews. So I am working to do more reviews, usually the stalest Bug Smash issues at NR.
jibran	@quietone I'll try to review stuff. Just trying to find some inspiration atm :slightly_smiling_face:
quietone	@jibran, I think that is why I made changes to the stats script. I wanted to see the short term progress. Just looking at open and fixed was not helping my enthusiam.
larowlan	time poverty
Grimreaper	Need a RTBC on #2359675: File field's Maximum upload size always passes validation
dww	@Grimreaper - set 2359675 to NW with some feedback. Thanks for working on it!

3️⃣ Core bug statistics - current state of open bugs

quietone	I modified lendude's stats program to do counts for a period of time. If correct this should be the stats for the fortnight starting 30 March 2021. `Open: 44 Closed: 74 Age Count 00 36 01 08 02 06 03 02 04 03 05 04 06 09 08 02 09 01 10 01 11 01 13 01 Status Count fixed 18 Status Count closed (duplicate) 20 closed (won't fix) 01 closed (works as designed) 06 closed (fixed) 33 closed (outdated) 06 closed (cannot reproduce) 08`
quietone	It does not count issue that no longer apply to D8+ and have been moved to D7. I have done a few of those.
Kristen Pol (she/her)	nice

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

quietone	https://www.drupal.org/project/drupal/issues/84883 needs review
quietone	Also at NR, https://www.drupal.org/project/drupal/issues/134209
danflanagan8	NR: https://www.drupal.org/node/3118590
dww	#1894286: System updates are executed without priority (critical with recent moment)
dww	#3008292: ImageItem::getUploadValidators() should be the source of truth for validating uploaded images is a major bugfix that probably just needs tests and a little more lovin' before it's RTBC...
dww	@quietone re-reviewed 84883...

5️⃣ Help me - Is there anything you could use a :hand:

jibran	@mohit.aghera if I'll point you in the direction can you write tests for #2915512: Entity query doesn't allow relationship specifier for base entity fields?
mohit.aghera	Yes, absolutely.
jibran	Let's discuss after the meeting.

6️⃣ DrupalCon contribution plan for Thursday bugsmash by @Kristen Pol (she/her)

Kristen Pol (she/her)	I see the open social group
Kristen Pol (she/her)	https://drupalcontributions.opensocial.site/group/automated-updates-and-...
Kristen Pol (she/her)	I don't know why it couldn't have been split into 2 groups though
Kristen Pol (she/her)	Weird... I'm very confused
Kristen Pol (she/her)	it shows 2 topics created by me but I don't recall creating them
Kristen Pol (she/her)	https://drupalcontributions.opensocial.site/node/13
Kristen Pol (she/her)	https://drupalcontributions.opensocial.site/node/12
Kristen Pol (she/her)	Unless my body was hijacked, I don't think that was me
Kristen Pol (she/her)	Oh... that's from March 30th... hmm
Kristen Pol (she/her)	ok, then I don't know... that's almost whole 2 weeks ago ;)
Kristen Pol (she/her)	but I still don't remember adding them
quietone	Did we make a list of issues to triage for this?
Kristen Pol (she/her)	I thought people said last meeting that, since triage is part of bugsmash, that it would happen on the day of?
Kristen Pol (she/her)	Though I may be misunderstanding/misremembering
quietone	OK, I just forgot.
Kristen Pol (she/her)	Is that correct? I'll go check the old notes
Kristen Pol (she/her)	Here's the thread: https://drupal.slack.com/archives/C014QES6HSQ/p1617078211046500
Kristen Pol (she/her)	Seems like it wasn't 100% clear but, if people wanted to have some good novice issues ready to give to new contributors, that could be helpful
Kristen Pol (she/her)	there was discussion of a triage session and a doodle but then I don't know what became of that... but I've been heads down on other things
Kristen Pol (she/her)	See triage thread that was just opened: https://drupal.slack.com/archives/C014QES6HSQ/p1618288394127500
Kristen Pol (she/her)	Who's in charge of mentoring on Thursday?
Kristen Pol (she/her)	I see the intro by @larowlan https://drupalcontributions.opensocial.site/node/42
Kristen Pol (she/her)	not sure who's going to be in the "reception" https://drupalcontributions.opensocial.site/node/53
mradcliffe	Okay, so we have a better idea now that the first day is over.
mradcliffe	Briefly what we're going to do is the Reception event can have up-to 8 breakout rooms. These can't have names, but I added some notes to those.
mradcliffe	Anyone set as an Organiser on that event node should have Moderator permissions to make people presenters and/or manage things.
mradcliffe	This should work well to collaborate on multiple issues in each breakout room.
mradcliffe	I'll be in the main Reception room for the entire time to help direct traffic.
mradcliffe	I currently have @Kristen Pol (she/her) @larowlan @lendude @quietone as organisers, and if anyone else needs it please ping me.
Kristen Pol (she/her)	Awesome
dww	Ooof. I'd be available to be in the Bug smash room(s), but I see "Breakout Room 6 - Improve the Drupal Core Update Module" and I should almost certainly be in there if I'm anywhere. :wink:
dww	Will we be able to lurk in multiple rooms?
Kristen Pol (she/her)	I read in another thread somewhere that we can be in multiple rooms at same time but I'm unclear how it works

7️⃣ Triage - Suggest an issue that needs triage.

quietone	@mohit.aghera what was the one you asked about a couple of days ago?
mohit.aghera	@quietone https://www.drupal.org/project/drupal/issues/159346#comment-4501946 (edited)
quietone	Looking at the issue, does changing the default have any BC concerns?
mohit.aghera	I can’t think of any specific issues that can come when we change the incorrect default values.

8️⃣ Anything anyone wants mentioned in the 'intro to bugsmash session' on Thu (Fri AEST timezone) by @larowlan

quietone	I've noticed that progress on an issue is correlated to the discussion/asking questions/asking for support/ etc about the issue in #bugsmash
jibran	Karma - People only look/review your issue faster if you generate some karma. (edited)
quietone	Help the reviewer - compete the IS (including screedshots), provide lots of detail. (edited)
larowlan	awesome feedback
mradcliffe	I'll be mentioning @larowlan's presentation in the keynote.

9️⃣ Can we setup Google Calendar notification for Triage time in this channel?

jibran	A question to slack admins
Kristen Pol (she/her)	I've done that for company calendars before and it was helpful... I haven't seen any of these pop up in any Drupal channels though
larowlan	google calendar is disabled in this workspace because of privacy reasons
jibran	How about IFTTT?

That’s a wrap folks, this Bugsmash meeting is over. Thanks all for coming!Please feel free to keep chatting in the threads.

larowlan

thanks Jibran :heart:

Participants:

Kristen Pol, mohit.aghera, quietone, gaurav mahlawat, jibran, Griffyn Heels, larowlan, lendude, Kunal Kapoor, anmolgoyal74, Michael (g-brodiei), Grimreaper, hansa11, mansoor20, Paulo Henrique Cota Starling, Guilherme Vitoriano Pereira, mradcliffe, dww, danflanagan8