Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Mar 2021 at 14:53 UTC
Updated:
29 May 2021 at 13:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
svenryen commentedThat would indeed be something we should have thought of. Thanks for catching this. Will have a look later. Patches are also welcome!
Comment #3
maximpodorov commentedComment #5
svenryen commentedComment #7
svenryen commentedTested and committed. Thanks for the patch!
Comment #9
maximpodorov commentedActually, we don't get any benefit here as domains are config entities, and we need to load them all and filter or apply ranges. So the real optimization is to add the configuration variable which allows to decide whether cookie banners should be domain dependent.
Comment #10
svenryen commented@maximpodorov, are you implying we should reopen this issue?
Comment #11
maximpodorov commentedI found that the fastest way is just to try to get the active domain. Any additional checks create more load.
Comment #12
maximpodorov commentedMoreover, iterating over all domains in EuCcClearCache.php can be too slow. I suggest to clear caches by invalidating cache tags.