I need a certain menu included in the sitemap not to show it's title. When changing the title of any menu included in the sitemap to blank, the default title still appears in the title field.
Review the file src/Plugin/Sitemap/Menu.php and check for the conditional of the returned value for the function
public function settingsForm(array $form, FormStateInterface $form_state)
Change the function above to return a blank value if no value is set.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | interdiff-3206374-6-8.txt | 255 bytes | gngn |
| #8 | sitemap-title-of-menu-not-saved-3206374-8-d8.patch | 979 bytes | gngn |
| #6 | 3206374.patch | 980 bytes | monojithalder |
| #2 | title-of-menu-not-saved-3206374-1.patch | 676 bytes | barone |
| Screenshot from 2021-03-30 07-50-06.png | 36.67 KB | barone |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8
Comments
Comment #2
baroneHere's the patch that fixes the menu label issue.
Comment #3
baroneComment #5
baroneComment #6
monojithalder commentedComment #8
gngn commentedThe patch in #6 renders an empty h2 title (if we set it empty in the config).
That is because of the ' ' (string with one blank) in Menu::view().
I see no reason for this (and I think empty h2 tags are invalid HTML).
So I propose to use '' instead of ' '.
Comment #12
dmitriy.trt commentedCreated MR !8 with the following alternative approach:
It's better to use changes of this MR together with MR !7 of #3231515: Save settings of enabled plugins only, because otherwise default titles only appear once on the module installation.
Comment #14
akalata commentedThanks @barone for the detailed write-up, everyone else for keeping this thread going, and to @dmitriy.trt for keeping the default values when a plugin is enabled.