Group invite module extends Group module.
This module allows group managers to invite people into their group.

Is a module based on the Issue Site admin or Group admin should be able to invite users to the group

Project link

https://www.drupal.org/project/ginvite

Git instructions

git clone --branch '1.0.x' https://git.drupalcode.org/project/ginvite.git

PAReview checklist

https://pareview.net/r/157

Comments

kuldeep_mehra27’s picture

Status: Needs review » Needs work

Hi,
Kindly fix below errors.

src/Event/UserRegisteredFromInvitationEvent.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
36 | ERROR | [x] There must be exactly one blank line before the tags in
| | a doc comment
--------------------------------------------------------------------------

src/EventSubscriber/GinviteSubscriber.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
14 | WARNING | [x] Unused use statement
66 | ERROR | [x] Additional blank lines found at end of doc comment
109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
--------------------------------------------------------------------------

src/Plugin/GroupContentEnabler/GroupInvitation.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
277 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
--------------------------------------------------------------------------

eduardo morales alberti’s picture

Thank you kuldeep_mehra27, I fixed that coding standard errors on this commit

eduardo morales alberti’s picture

Status: Needs work » Needs review
bramtenhove’s picture

Status: Needs review » Needs work

I ran the project through PAreview: http://pareview.net/r/129.

Please add a README explaining the module according to the guidelines at https://www.drupal.org/docs/develop/documenting-your-project/module-documentation-guidelines#readme. The README template might help as well: https://www.drupal.org/node/2181737.

From a code perspective I would say we're good.

eduardo morales alberti’s picture

Status: Needs work » Needs review

Thanks bramtenhove, we add more documentation, we added a README.md and also the hook_help

bramtenhove’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the quick response Eduardo.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update the project to opt it into security coverage.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

eduardo morales alberti’s picture

Thank you so much for your recommendations kiamlaluno

avpaderno’s picture

Title: [D8], [D9] Group invite » [D8] Group invite
eduardo morales alberti’s picture

kiamlaluno Group Invite is compatible with drupal 8 and Drupal 9, we must change the name of the release maybe, and remove the core version.

https://www.drupal.org/pift-ci-job/2033653

avpaderno’s picture

The title isn't supposed to say every Drupal version with which the project is compatible. It's just an indication for the reviewers to understand which code are going to review, or the reviewed code. In this case, it's more important that the code is compatible with Drupal 9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.