Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
24 Mar 2021 at 09:33 UTC
Updated:
30 Apr 2021 at 13:14 UTC
Jump to comment: Most recent
Comments
Comment #2
kuldeep_mehra27 commentedHi,
Kindly fix below errors.
src/Event/UserRegisteredFromInvitationEvent.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
36 | ERROR | [x] There must be exactly one blank line before the tags in
| | a doc comment
--------------------------------------------------------------------------
src/EventSubscriber/GinviteSubscriber.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
14 | WARNING | [x] Unused use statement
66 | ERROR | [x] Additional blank lines found at end of doc comment
109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
--------------------------------------------------------------------------
src/Plugin/GroupContentEnabler/GroupInvitation.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
277 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
--------------------------------------------------------------------------
Comment #3
eduardo morales albertiThank you kuldeep_mehra27, I fixed that coding standard errors on this commit
Comment #4
eduardo morales albertiComment #5
bramtenhove commentedI ran the project through PAreview: http://pareview.net/r/129.
Please add a README explaining the module according to the guidelines at https://www.drupal.org/docs/develop/documenting-your-project/module-documentation-guidelines#readme. The README template might help as well: https://www.drupal.org/node/2181737.
From a code perspective I would say we're good.
Comment #6
eduardo morales albertiThanks bramtenhove, we add more documentation, we added a README.md and also the hook_help
Comment #7
bramtenhove commentedThanks for the quick response Eduardo.
Comment #8
avpadernoThank you for your contribution! I am going to update the project to opt it into security coverage.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #9
eduardo morales albertiThank you so much for your recommendations kiamlaluno
Comment #10
avpadernoComment #11
eduardo morales albertikiamlaluno Group Invite is compatible with drupal 8 and Drupal 9, we must change the name of the release maybe, and remove the core version.
https://www.drupal.org/pift-ci-job/2033653
Comment #12
avpadernoThe title isn't supposed to say every Drupal version with which the project is compatible. It's just an indication for the reviewers to understand which code are going to review, or the reviewed code. In this case, it's more important that the code is compatible with Drupal 9.