need to support drupal 9 and have no compatibility issues

CommentFileSizeAuthor
drupal9-readiness-1.patch365 bytesmohamed nabawy

Issue fork contribute-3204237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mohamed nabawy created an issue. See original summary.

adriancid’s picture

Status: Needs review » Closed (works as designed)

The code is in the dev branch

hotwebmatter’s picture

For those of us trying to upgrade now:

THIS IS THE WAY:
composer require 'drupal/contribute:1.x-dev@dev'

Or check for a newer dev release on the project page.

I thought this simple advice was worth spelling out, because some may habitually use the trick of using cweagans/composer-patches to apply patches via composer.json like so:

DON'T DO THIS! THIS IS NOT THE WAY:

    "extra": {
        "enable-patching": true,
        "patches": {
            "drupal/contribute": {
                "Drupal 9 compatibility patch": "https://www.drupal.org/files/issues/2021-05-03/entity_activity-drupal_9_readiness-3129711-7.patch"
            }
        },

There's a tricky reason why you can't use the patch here:
https://www.mediacurrent.com/blog/how-fix-catch-22-problem-drupal-9-fixe...

Short version: Composer can only patch a package that it can select for installation, so the core_version_requirement: ^8 || ^9 cannot be added by patching via composer.json.

In this case, just install the latest dev version:

composer require 'drupal/contribute:1.x-dev@dev'

... and you'll be ready for Drupal 9.

drupalfan2’s picture

Status: Closed (works as designed) » Needs work

Please provide a Drupal 9 version on project page!
Until then this issue should remain open.

joshua1234511 made their first commit to this issue’s fork.

joshua1234511’s picture

Version: 8.x-1.0-beta8 » 8.x-1.x-dev
Category: Support request » Task
Status: Needs work » Needs review
Issue tags: +Needs manual testing
adriancid’s picture

Status: Needs review » Fixed

@joshua1234511 will be better to create a new issue and a new patch for your PR

adriancid’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.