Olivero Meeting 2021-03-29 [#3203660]

Meeting Agenda

Introductions
Status and whats next
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Notes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every other Monday at 2pm UTC (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3203660: Olivero Meeting 2021-03-29

mherchel	:wave: Good morning
gaurav mahlawat	Hello.
AmyJune (volkswagenchick she/her)	Good day everyone!
thejimbirch	:wave:
brianperry	Hi all!
proeung	Hello :wave:
Indrajith KB	Hi :wave:
shaal	Hello :wave:
markdorison	Morning
adam	:wave:
anmolgoyal74	Hi:wave:
mradcliffe	Hi :wave:
hansa11	Hello :wave:
mansoor20	Hi :wave:

1️⃣ Overall project status update

mtift	This tread is for discussing the overall status of the Olivero initiative in broad terms, and we'll save specific issue discussions for later threads.
mherchel	Deadline for reaching stable is May 17 IIRC. I’m feeling a bit more optimistic than I was two weeks ago. We made a good amount of progress on automated tests, but still have a number of accessibility issues in front of us.
AmyJune (volkswagenchick she/her)	I’m curious how much was accomplished at MidCamp @mherchel?
mherchel	@AmyJune (volkswagenchick she/her) SO MUCH. Lots of testing:#3205434: Add Nightwatch Test Coverage for Olivero
AmyJune (volkswagenchick she/her)	Rad. thanks a lot for the update.
brianperry	@AmyJune (volkswagenchick she/her) it was great! Especially cool is that there were a lot of different contributors on those issues during the sprint, all working within the new MR workflow.
brianperry	@AmyJune (volkswagenchick she/her) also a first time contribution in there!
mradcliffe	It was great to be able to participate this weekend. I'll probably need to task switch to some other responsibilities, but it was great to contribute.

2️⃣ Individual issue discussion

mtift	This thread is the place to bring up specific issues that need some extra discussion
mherchel	I’d love to get a current status update on #3174107: Add additional testing coverage for Olivero
mherchel	And I need a review on this #3200370: Fix Olivero's drop-button style to conform with new form styles
brianperry	For the main testing issue, my understanding is that all that remains is coverage for olivero_preprocess_field__comment. There is a start for that in the MR, but it needs to be completed.
mherchel	Thanks!
brianperry	Need to catch up on some project work early this week, but if no one picks up the Nightwatch review I should be able to take a look later in the week.
proeung	The language switcher component still needs some design inputs. @Jen Witkowski This is a good one to take a look, if you're free (see issue - #3127588: Theme Olivero's language switcher).
mradcliffe	The test coverage on some of the preprocess functions still needs work on the unit test PR.
mradcliffe	@mherchel, is it beter to leave reviews on GitLab MR or use Dreditor/Issue queue?
brianperry	@mradcliffe was it just down to olivero_preprocess_field__comment or is there something else remaining on the unit test issue?
mradcliffe	Yes, that one needs some additional tests for when currentUser is authenticated.
mradcliffe	And I think the one I worked on is missing some coverage potentially.
mherchel	It doesn’t matter. I’m still getting used to the new workflow. But I’ll work with either
mradcliffe	mglaman's tests have really great code coverage.
mradcliffe	with lots of potential inputs.
mradcliffe	Should we add the Needs accessibility review to the Nightwatch testing issue to help review it?
brianperry	That probably makes sense since #3191077: Olivero narrow/mobile menu constrains tabbing in one direction only. has that tag.

3️⃣ Where can people help this week?

mtift	Share your suggestions here
mherchel	I would love if someone a11y minded could perform this #3190262: [META] Assess Olivero for WCAG Resize Text and Reflow success criteria.
mherchel	This is something that also needs to be taken care of #3182200: Follow proper BEM syntax within secondary navigation menu
thejimbirch	Asking out A11Y peeps to check out 3190262

Participants:

mherchel, gaurav mahlawat, AmyJune (volkswagenchick she/her), thejimbirch, brianperry, proeung, Indrajith KB, shaal, markdorison, adam, anmolgoyal74, mradcliffe, hansa11, mansoor20, mtift