Problem/Motivation

Starting with 29a77e8c6eb7db15c3bc73c66c8f003b6960cee3, the minimum requirements of this module was raised to PHP 7.3, however this isn't captured in the composer.json. The minimum requirements of 8.8.0 (which is the lowest version of Drupal core supported at this version of DS) is php >=7.0.8.

PHP Documentation shows that the array assignment equivalent of list() was added in 7.3...

I know that <=7.2 is End of Life making this a minor bug, but some hosting situations still haven't caught up, and I feel like having this documented is better than the alternative.

Error message for searchability

ParseError: syntax error, unexpected '=' in /app/web/modules/contrib/ds/ds.module on line 540

Issue fork ds-3203249

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

generalredneck created an issue. See original summary.

generalredneck opened merge request !4

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Active » Needs review

Saw the "Not Currently Mergeable" and got confused... sorry about all the noise. This should be ready for review.

swentel’s picture

swentel commented

Oh crap, it wasn't intentional to break older PHP versions, will commit in the morning and release, thanks for the catch!

First pull request too, hope that goes well ... :)

swentel’s picture

swentel commented
Priority: Normal » Critical

Moving to critical so I really don't forget.

swentel’s picture

swentel commented
Status: Needs review » Fixed

merged, thanks!

Will do a new release after I get #3200938: Error on "Manage display" for entity without bundle: The "" entity type does not exist in as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.