Problem/Motivation

Issue with additional image format support for block field image.
Does not support adding additional image extensions.
Values are hardcoded at:
https://git.drupalcode.org/project/svg_image/-/blob/8.x-1.x/src/Plugin/F...
Line 185
// If not using custom extension validation, ensure this is an image.
$supportedExtensions = ['png', 'gif', 'jpg', 'jpeg', 'svg'];

Steps to reproduce

Enable additional image formats from image toolkit, add a new or edit exiting image field for block. The new extension will not be enabled for the image field.

CommentFileSizeAuthor
#6 After patch user is able to successfully upload svg extension image in image field.png172.64 KBmanojithape
#6 After patch newly added extension displayed on image field as a helptext.png17.58 KBmanojithape
#6 Before patch user not able to upload svg extension image.png34.53 KBmanojithape
#6 Before patch svg extension added at time of field setting.png19.82 KBmanojithape
#2 fix-to-allow-additonal-image-extentions-3203173-2.patch958 bytesjoshua1234511

Comments

joshua1234511 created an issue. See original summary.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
StatusFileSize
new fix-to-allow-additonal-image-extentions-3203173-2.patch958 bytes

Added a patch for the fix.
The supported extensions an are fetched from the core image factory and the required svg format is added for the same.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Status: Active » Needs review

Setting Status to Needs review

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
StatusFileSize
new Before patch svg extension added at time of field setting.png19.82 KB
new Before patch user not able to upload svg extension image.png34.53 KB
new After patch newly added extension displayed on image field as a helptext.png17.58 KB
new After patch user is able to successfully upload svg extension image in image field.png172.64 KB

Verified and tested patch#2. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install svg image module
  2. Go to Extend-> Search "svg image" and install module. add a new or edit existing image field for the block with supported SVG extension.
  3. Observe user is not able to upload the .svg extension image file
  4. Apply patch and again try to upload an image file with a .svg extension and verify a user is able to upload a .svg image.

Testing Results:
Now the user is able to upload a newly added extension image in the image field i.e. a .svg extension.

Moving this ticket to RTBC.

manojithape’s picture

manojithape commented
Status: Needs review » Reviewed & tested by the community
manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned
imyaro’s picture

imyaro commented
Status: Reviewed & tested by the community » Closed (duplicate)

It was fixed in the different issue.
Thank for your help!