Problem/Motivation

The Drupal 7 version of Notify used a CSS-styled table to display tabular data under the "Skip flags" and "Users" tab.

It used to look like this:

D7 screendump

But currently, it looks like this:

D8 screendump

These are not styled in the D8/9 version of the project.

Steps to reproduce

Just visit the "Skip flags" and "Users" tab. Tabular styling is missing.

Proposed resolution

Provide theming to make this to appear like they in the Drupal 7 version.

User interface changes

Tabular data under these tabs will be styled in a tabular format.

CommentFileSizeAuthor
#4 3202995-4.patch7.04 KBlarisse
notifyusers.png18.08 KBgisle

Comments

gisle created an issue. See original summary.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes

Added screendump from #2952310: bulk user screen UI needs formatting.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 8.x-1.x-dev » 2.0.x-dev

Changing version to current D8/D9 branch.

larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3202995-4.patch7.04 KB

Hi! I create a patch for this bug!

  • larisse authored fbe9d3c on 2.0.x 
    Issue #3202995 by larisse, gisle: Fixed unthemed form in UsersForm.php
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Needs work

Patch of UsersForm.php fixes the bug in that table. These have been committed.

Patch of SkipForm.php produces the following errors when there are posts queued:

Notice: Undefined index: nid in Drupal\notify\Form\SkipForm->buildForm() (line 145 of modules/contrib/notify/src/Form/SkipForm.php).
Notice: Undefined index: cid in Drupal\notify\Form\SkipForm->buildForm() (line 148 of modules/contrib/notify/src/Form/SkipForm.php).
Notice: Undefined index: created in Drupal\notify\Form\SkipForm->buildForm() (line 152 of modules/contrib/notify/src/Form/SkipForm.php).
Notice: Undefined index: updated in Drupal\notify\Form\SkipForm->buildForm() (line 155 of modules/contrib/notify/src/Form/SkipForm.php).
Notice: Undefined index: title in Drupal\notify\Form\SkipForm->buildForm() (line 158 of modules/contrib/notify/src/Form/SkipForm.php).
Notice: Undefined index: dist in Drupal\notify\Form\SkipForm->buildForm() (line 162 of modules/contrib/notify/src/Form/SkipForm.php).

  • gisle authored 5779020 on 2.0.x 
    Issue #3202995 by gisle, larisse: Fixed unthemed form in SkipForm.php
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs work » Fixed

Fixes to SkipForm.php also pushed to the latest snapshot of 2.0.x-dev. Thanks for the patch.

larisse’s picture

larisse commented

Thank you @gisle

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.