Meeting of the Bug Smash Initiative 2021-03-16 [#3201534]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Blockers
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on target items from last meeting
What should be the initiative focus for the next 2 weeks?

New Items

Add agenda items here

ToDos

who?	Prepare triage issue list for DrupalCon, BugSmash day is Thursday

Hi and welcome to the fortnightly meeting of the Bug Smash community initiative in 2021 :beetle::hammer::tada:This meeting:➤ Is for contributors who are interested in helping reduce the number of open bugs against Drupal 8 and Drupal 9 core.➤ Usually happens every second Tuesday at 04:00 UTC.➤ Is done over chat.➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!➤ Transcript will be exported and posted to a core issue for this meeting. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

larowlan	:wave: lee Australia, late off the mark
mohit.aghera	Mohit, India :blob_wave:
quietone	Vicki, NZ. A non-sailor enjoying the America's Cup
gaurav mahlawat	Gauravmahlawat India
Neslee	Neslee, Valencia
anmolgoyal74	Hello.. Anmol from India :flag-in:
dww	Breonna Taylor. #SayHerName and #BlackLivesMatter . US :fist::skin-tone-6:
lendude	Len, Amsterdam, trying to wake up...and failing
jibran	Jibran, AU, Catching up.
hansa11	Hansa, India :wave:
mansoor20	Hello :wave:Catching up the on the threads now.
Matroskeen	Ivan, UA
kimb0	Kim, Au
Kristen Pol (she/her)	Kristen, California, late
Paulo Henrique Cota Starling	Paulo Henrique (paulocs), Belo Horizonte - Brazil
xjm	:wave: Reading the next day

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

dww	Any news on bugsmash @ DrupalCon?
quietone	What to do with issues about coding standards, type hints, @something errors. Some are bugs, some are not. What component for them?
quietone	I was also wondering what will happen to all the D7 issues once it is EOL.

2️⃣.1️⃣ Wins - what wins have you had since the last meeting in December? Share your successes!

dww	Happy to have written a blog post about our initiative, and that it was well-received: https://ten7.com/blog/post/why-ten7-actively-supports-drupal-bug-smash-i...
mohit.aghera	#2751269: Submitting a comment in the non default language redirects you to the default language (edited)
larowlan	the RTBC one is on my list, will take a look tomorrow mohit
Kristen Pol (she/her)	I figured out what I'll be doing in April for DrupalFest... it'll include bugsmash some of the time :slightly_smiling_face: https://twitter.com/kristen_pol/status/1371195205131530241?s=20

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

larowlan	callout for @mohit.aghera seeing you dropping into a heap of issues and adding tests, thanks!
jibran	Thank you to every one who helped with the group triage last week.
jibran	https://drupal.slack.com/archives/C014QES6HSQ/p1615262571151600

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

larowlan	busy at work
quietone	America's Cup :smile:
Kristen Pol (she/her)	Not fun: legal stuff for my mom.Fun stuff: Snow today for about an hour! After having really nice weather yesterday. First time seeing snow it a long time.I'm trying to get a bunch of other stuff done so I can spend a lot of focus Drupal time in April for DrupalFest.

3️⃣ Core bug statistics - current state of open bugs

larowlan	50 closed issues this fortnight
larowlan	69 new issues :disappointed:
quietone	The closed ones include a 12 yr old, a 10 yr old, 3 9 yrs old ans some 8 yr etc. I like to think of that as a win.
larowlan	:tada:
Matroskeen	I didn’t find the most relevant topic, so I’ll post it here :slightly_smiling_face:Recently, I reviewed my old issues, where I was the original author and found one, that can be closed as “Won’t fix”.I’m gonna ask my teammates to do the same, and encourage every bugsmasher to do the same.The good thing is - in this case we don’t need to wait several months for the confirmation from someone, because the author can easily identify if the issue still exists and it’s relevant. (edited)

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

dww	Hope you work on #2350711: Update module fails on installation — will need someone else to review since I’ve written some of the patches.
mohit.aghera	Figure out test cases for #3187004: DrupalDateTime serialization issue
mohit.aghera	Resolve the comments #2710469: Move contact module footer link to standard install profile#comment-13920746

5️⃣ Help me - Is there anything you could use a :hand:

Kristen Pol (she/her)

I wasn't able to reproduce this because my local keep freezing but I added more steps for what I think should be how to reproduce it if someone could try them: #3196984: libraries-override failed: ckeditor/drupal.ckeditor.plugins.drupalimagecaption

6️⃣ Any news on bugsmash @ DrupalCon? via @dww

larowlan	We have a 15 minute session on the Wednesday, I'm going to present the slides pameeela and lendude have used before
dww	All I know is there was a thread from @hestenet (he/him) about swapping g the schedule around, not sure if there was actually a change.
larowlan	Then after that I think is our contribution day
dww	I might be able to play some live music before (and/or after) our session if we want that and there’s a gap betwn meetings. Depending on the scheduling...
dww	Plan for contrib day is just to have a bunch of mentors in channel to help direct / unblock folks?
larowlan	I'm not sure how its setup, but perhaps ask Rachel Norfolk or hestenet?
larowlan	(^ in relation to the music)
Kristen Pol (she/her)	I'm also curious how organized we want to be for DrupalCon. Should we triage before that so there are some ready for patches/next steps?
lendude	Or should we set up some triage lists, like my reverse last update ordered Views list, except you know, less scary :wink: https://www.drupal.org/project/issues/search/drupal?project_issue_follow...…]submitted=&issue_tags=&&order=last_comment_timestamp&sort=asc
lendude	Maybe filtered on Active status or something so there is less chance of getting dragged down into 100+ comment issues
hestenet (he/him)	So AutoUpdates + BugSmash day is now Thursday, fwiw
hestenet (he/him)	And the intro session is at the end of the session block right before contrib time starts
hestenet (he/him)	And yeah - some triage would be great prep - but up to you how in-depth you want to be :slightly_smiling_face:
Kristen Pol (she/her)	Triage lists sound good
xjm	Your mentoring team rep should help you with triage and planning -- I'm not sure if @mradcliffe is helping with both autoupdates and bugsmash, or if we have another mentor lead for bugsmash. I'll ask the mentor channel. (edited)
xjm	Looks like it will indeed be @mradcliffe as mentor lead -- I'd recommend reaching out to him to chat specifically about the sprint (edited)

7️⃣ What to do with issues about coding standards, type hints, @something errors. Some are bugs, some are not. What component for them? via @quietone

larowlan	A lot of these could probably be tasks?
quietone	I would think so but I have not yet found a guidelines about that.
quietone	And which fixes will be done by a sniff and which will not.
dww	Component Kinda depends on scope.If it’s cleaning up something in a specific module, probably best to use that module’s component.If it’s a “unify style for foo operator” not sure we have a good catch-all.If it’s doc / comment only stuff, could use “documentation” component.
larowlan	for coding standards, we try to fix a whole rule in one issue, and add the sniff into the phpcs.xml so it doesn't come back
larowlan	so any issues that are 'fix phpcs in module x' are not scoped correctly, we scope by rule, not module
larowlan	and would be closed as duplicate, linking back to the meta
quietone	OK, that helps. Maybe I can do something useful with these types of issues when I stumble onto them in the future.
larowlan	here's the meta for PHPCS #2571965: [meta] Fix PHP coding standards in core, stage 1 - all the child issues are for 'Fix sniff x'
quietone	Yes, those are easy to spot. (And nice to see YAML linting)
dww	Agreed on phpcs & scope. I was talking more about doc-only cleanups being potentially per-module.
dww	But I guess I had the wrong scope for this thread. Oh the irony! ;)
xjm	Yep, coding standards cleanups are typically task/other if it's implementing a new rule. It'd only be a bug if something regressed an existing rule (which for rules that are enabled would break HEAD).

8️⃣ I was also wondering what will happen to all the D7 issues once it is EOL via @quietone

larowlan	I think Closed (outdated) is what happened to D6 issues that didn't impact D7
quietone	That implies a process to examine the issues to see if they apply to D8+
larowlan	eek
quietone	Exactly!
lendude	Since we’ve been pretty clear from the start that we do D8 first and then backport, I’d hope that most of that kind of triage happend somewhere in the last 6 years. So maybe make a list of D7 issues that haven’t been touched in 6 years and see how bad that is? Dunno.
Kristen Pol (she/her)	Sounds potentially daunting but it would be nice if a bunch can be closed quickly because they no longer apply... so much code changed that I imagine that this will be the case
xjm	Yes, they will be bulk closed as Closed (Outdated) like the D6 issues were after D7 reaches EOL (two years from now)

Participants:

larowlan, mohit.aghera, quietone, gaurav mahlawat, Neslee, anmolgoyal74, dww, lendude, jibran, hansa11, mansoor20, Matroskeen, kim.pepper, Kristen Pol, Paulo Henrique Cota Starling, xjm, hestenet