Add token module as dependency [#3200715]

Hi all,

First off thank you for this module.

Just a quick note to let you know that it currently does not include the token in the dependencies, thus a user can enable this module but it has no function.

I'm not a programmer so haven't worked out how to contribute a patch but I think it's something about changing the .yml file to add:

dependencies:
  - token:token

¯\_(ツ)_/¯

Comment	File	Size	Author
#6	AfterPatch.png	102.16 KB	shalvimukherjee
#6	BeforePatch.png	94.61 KB	shalvimukherjee

Issue fork token_views_filter-3200715

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3200715-add-token-module changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 February 2021 at 23:10

dx1 created an issue. See original summary.

Comment #2

14 March 2021 at 06:03

suraj2012 made their first commit to this issue’s fork.

Comment #3

suraj2012 commented 14 March 2021 at 06:15

Assigned:

Unassigned

» suraj2012

Comment #4

14 March 2021 at 06:28

suraj2012 opened merge request !1

Comment #5

suraj2012 commented 14 March 2021 at 06:35

Component:	Documentation	» Code
Assigned:	suraj2012	» Unassigned
Status:	Active	» Needs review

Comment #6

shalvimukherjee commented 27 April 2021 at 10:54

Status	File	Size
new	BeforePatch.png	94.61 KB
new	AfterPatch.png	102.16 KB

Verified and tested the patch. Patch applied successfully and looks good to me.

Testing steps:
1. Install Tokens in Views Filter Criteria module
2. Go to admin/modules and check dependencies for Tokens in Views Filter Criteria - Token module dependency is not present
3. Apply the patch and check for dependencies in module description and in admin/modules

Testing result-
Token module is required.

Moving this ticket to RTBC.