jQuery UI dialog's select elements do not contain dropdown chevron in Safari

This can be replicated by going into a CKEditor comment form, changing the input mode to "full HTML" and adding a table via the CKEditor table plugin. The dialog modal that appears will display this bug.

CommentFileSizeAuthor
#3 Screenshot 2021-03-03 at 10.28.07.png43.46 KBgauravvvv
#3 Screenshot 2021-03-03 at 10.28.33.png40.98 KBgauravvvv
#2 safari.png27.72 KBmherchel
#2 firefox.png27.26 KBmherchel
#2 chrome.png30.85 KBmherchel
#2 3200631.patch972 bytesmherchel
safari-dialog-select.png197.96 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
Issue tags: +CSS
StatusFileSize
new 3200631.patch972 bytes
new chrome.png30.85 KB
new firefox.png27.26 KB
new safari.png27.72 KB

Patch attached. Screenshots of Chrome, FF, & Safari are below (IE is not affected because of it uses the ::-ms-expand selector)

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 2021-03-03 at 10.28.33.png40.98 KB
new Screenshot 2021-03-03 at 10.28.07.png43.46 KB

Patch #2, works fine for me. Adding screenshots of different browsers after the patch.
RTBC +1

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the review! Don't forget to change the status to RTBC when you RTBC issues :D

  • lauriii committed 468d666 on 9.2.x 
    Issue #3200631 by mherchel, Gauravmahlawat: Olivero: jQuery UI dialog's...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 468d666 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.