Olivero's small button variation's text seem vertically mis-aligned

CommentFileSizeAuthor
#10 After Patch 3200628.png470.79 KBchetanbharambe
#10 Before Patch 3200628.png440.64 KBchetanbharambe
#7 3200628-7.patch859 bytestushar_sachdeva
#4 Screenshot 2021-04-19 at 2.42.44 PM.png11.94 KBtushar_sachdeva
#4 3200628-4.patch1.27 KBtushar_sachdeva
small-variation.png124.88 KBmherchel

Comments

mherchel created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented

Hi @mherchel, Please write the steps to reproduce this issue. or Is this available on the live preview? https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/

tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: Unassigned » tushar_sachdeva
tushar_sachdeva’s picture

tushar_sachdeva commented
StatusFileSize
new 3200628-4.patch1.27 KB
new Screenshot 2021-04-19 at 2.42.44 PM.png11.94 KB

The easy way to reproduce @gaurav mahlawat is to just create an article page and in inspect section replace button--primary with --small
Quick and easy patch applied. Please refer screenshot attached.

tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: tushar_sachdeva » Unassigned
Status: Active » Needs review
aaron.ferris’s picture

aaron.ferris commented

This feels a bit funky to have a variable called --line-height-normal that's 1px.

It's a bit far from normal, no? :)

tushar_sachdeva’s picture

tushar_sachdeva commented
StatusFileSize
new 3200628-7.patch859 bytes

Added Line-height to normal for button--small.

tushar_sachdeva’s picture

tushar_sachdeva commented

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch 3200628.png440.64 KB
new After Patch 3200628.png470.79 KB

Verified and tested patch #7.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Content -> Create an Article page
# Save it
# View the buttons
# User is able to see variation's text seems vertically misaligned.

Expected Results:
# User should see variation's text properly aligned with Line-height.

Actual Results:
# User is able to see variation's text seems vertically misaligned.

Looks good to me.
Can be a move to RTBC.

  • lauriii committed a442cd7 on 9.3.x 
    Issue #3200628 by tushar_sachdeva, chetanbharambe, mherchel: Olivero's...

  • lauriii committed 48ae3d7 on 9.2.x 
    Issue #3200628 by tushar_sachdeva, chetanbharambe, mherchel: Olivero's...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed a442cd7 and pushed to 9.3.x and 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.