The filter throws a PHP Notice warning relating to the return value of the SoEmbedFilter->embed() method when
Add the soembed filter on a text field with the soembed filter setup and view content. If you have PHP configured to display all errors you will get the PHP Notice warning.
The embed() function returns rendered HTML which is sandwiched between index 1 and 3 of the $match array.... it's not clear to me the purpose of wrapping the returned HTML output in those values.
Removing the $match[0] and $match[3] wrappers fix the issue and don't break the (already) rendered HTML output.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | undefined-offset-3199585-1.patch | 467 bytes | cossovich |
Comments
Comment #2
cossovich commentedPatch added with only the rendered HTML output returned from embed() method.
Comment #3
WebbehBased on #2, for review?
Comment #4
WebbehComment #5
ki commentedThe wrapping characters are restored back to complete the original tags. In most case with ckeditor, they would be
<p>and</p>. However, I've fixed the warning with??operator.Comment #6
ki commentedComment #7
ki commented