There’s lots of code smell and incomplete documentation in our Views code, and while most of it is (argueably) Views’ fault, we should fix what we can.

CommentFileSizeAuthor
#3 3199552-3--views_code_cleanup.patch7.16 KBdrunken monkey
#3 3199552-3--views_code_cleanup--interdiff.txt956 bytesdrunken monkey
#2 3199552-2--views_code_cleanup.patch7.86 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3199552-2--views_code_cleanup.patch7.86 KB

Would love to also add more type hints, but too dangerous in case other plugins inherit from ours.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3199552-3--views_code_cleanup--interdiff.txt956 bytes
new 3199552-3--views_code_cleanup.patch7.16 KB

Reroll and a little more cleanup.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.