Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues:

Agenda Items

Add your items here.

0️⃣ Who is here today? What is your favorite thing to cook?

benjifisher Benji Fisher, one of the maintainers of the migration subsystem. My favorite dish is chicken biriyani, but I have not made it in a long time. It is an all-day affair,
dinarcon :wave: Mauricio here
benjifisher @anmolgoyal74, please introduce yourself in this thread. If there is something you would like to talk about, add it to 1️⃣.
quietone Vicki. Black-eyed bean stew.
anmolgoyal74 Anmol Goel :wave:, Developer from opensense labs, India.
benjifisher Vicki, is "black-eyed bean" the same as "black-eyed pea"? And what else goes into the stew?
damienmckenna Damien. Pavlova.
jibran Jibran, AU. Benji there are way to cook it quicker as in a couple of hours.
gaurav mahlawat Gauravmahlawat from Delhi India :flag-in:

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

dinarcon Now that Drush 10.4 has been released, it would be good to talk about required changes for migrate_tools https://gitlab.com/drupalspoons/migrate_tools/-/issues/118
quietone How to get issues reviewed.
quietone #2783423: Taxonomy terms not displayed after migration - Is this outdated
quietone Decide which week(s) the next video call should be in

2️⃣ Action items. To be added later.

quietone Add date for video call meeting to the IS of the next meeting minutes. @quietone
quietone Work on #3184650: ContentEntity migration source adds revision ID as source key, incompatible with Drupal 8.8 and earlier @quietone

3️⃣ Statistics

benjifisher Fixed since last week's meeting: 3 (not counting the issue for the meeting).
benjifisher RTBC: 7, 1 of which is Minor, the rest Normal. All have been updated in the last two weeks.
benjifisher NR: 43, including 1 Critical and 4 Major and 1 that has not been updated in more than two months.
benjifisher That is a lot of issues that need review! Remember, if you can test but not review the code, that is still helpful!
quietone And for those new to reviewing code, ask questions in #migration

4️⃣ How can I help? Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

anmolgoyal74 I would like to help in testing.One thing i really want to know that what are the efficient ways to test issues related to migration.
benjifisher For manual testing, I set up a local development environment and install Drupal 7. I think I also did Drupal 6 in another instance. Add some content, either manually or using Devel Generate, and then make a database backup.
benjifisher Then set up a local site with Drupal 9. I use Lando, but you can use your preferred system. Either add additional containers/services for the D6, D7 databases or create additional databases on the main db container.
benjifisher This is my Lando config. I do not have it set up for both D6 and D7.name: drupalrecipe: drupal8config: webroot: .services: d7db: type: mysql:5.7 portforward: true creds: user: d7 password: d7 database: databasetooling: phpunit: service: appserver user: www-data cmd: - appserver: /app/vendor/bin/phpunit -c /app
benjifisher Then drush si standard and drush en migrate_drupal_ui and you are ready to test most core migration issues.
quietone Using the tag 'Migrate UI' you will find 3 issues at NR, all that could use manual testing
quietone The is a doc page we can add to for helping people get started with testing migration issues, https://www.drupal.org/docs/upgrading-drupal/contributing-to-migrate
anmolgoyal74 Thank you @benjifisher. This is something I will try over the weekend. I will pick one of the issues from the list mentioned by @quietone.

5️⃣ ContentEntity migration source adds revision ID as source key, incompatible with Drupal 8.8 and earlier

benjifisher #3184650: ContentEntity migration source adds revision ID as source key, incompatible with Drupal 8.8 and earlier
benjifisher @quietone, I added a few comments and ended up agreeing with alexpott, so I think the update needed for this issue is pretty clear.
quietone I will look at it today
benjifisher Thanks!

6️⃣ Migrate commands are now part of Drush core

benjifisher https://gitlab.com/drupalspoons/migrate_tools/-/issues/118
benjifisher Thanks for the reminder, @dinarcon. I have been meaning to look at this for over a month, but I have been too busy .. especially in the last week.
dinarcon I had a look, but it is over my head. :disappointed: I would like to help with this. It'd be up for pair programming with someone on this.
benjifisher Have you done any testing? What is the current state? That is, if it is broken, how bad is it?
quietone The limit feature wasn't working for me with drush mim. Anyone experience that?
benjifisher I have not tested Drush 10.4 at all. :disappointed:
dinarcon Well, Drush 10.4 declares a conflict with Migrate Tools <= 5. It is not even possible to install it.
benjifisher I guess Migrate Tools provides the UI as well as the Drush commands. If you install Drush 10.4 and Migrate Plus, what do you get?
damienmckenna Sounds like we need a new branch of Migrate Tools that doesn't have the Drush commands.
benjifisher @heddn ^
heddn that sounds right

7️⃣ Deprecate Migration::set()

benjifisher #2796755: [PP-1] Deprecate Migration::set()
benjifisher @quietone, sorry I have not replied to your later patch. I think it can be done more simply.
quietone OK. I look forward to your review.
benjifisher It is pretty much what I said in my previous review (#85), although you were not sure what to do with that.
benjifisher I do not like the approach of having a method in the base class peek at the destination plugin and, if appropriate, add the file locations as extra configuration.A big part of this issue is simplifying code by setting the configuration when the plugin is instantiated, by passing config to the plugin manager's create() method (IIRC). I think the tests should do the same thing.
benjifisher If you search for test classes that use the file trait, there are only about 6. Then look for the places where createMigration() or createMigrations() are used. I think only 2 or 3 of those are file migrations. In those 2 or 3 places, we can add the extra configuration.
quietone I do not like the approach of having a method in the base class peek at the destination plugin and, if appropriate, add the file locations as extra configuration.Agree. And this problem for files has not been solved for the UI either, https://www.drupal.org/node/2804611
quietone Do these comments apply to the patch in #91? The latest patch has removed getMigration from the d7 file test trait.

8️⃣ Only migrate role permissions that exist on the destination

benjifisher #2953111: Only migrate role permissions that exist on the destination
benjifisher @andypost, do you have time to re-review this one?

9️⃣ How to get issues reviewed.

benjifisher I guess there are two parts to this:How can we encourage more people to review issues?How can I get started reviewing an issue?
quietone That sounds right to me.
Matroskeen You can also consider the opposite direction:How to encourage people stop creating new issues and submit patches
Matroskeen Btw, I’m gonna create a few more this week with documentation improvements :smiling_imp:

1️⃣0️⃣ Taxonomy terms not displayed after migration (edited) 

benjifisher #2783423: Taxonomy terms not displayed after migration
quietone mikeryan's comments suggests there is nothing to do here? #2783423: Taxonomy terms not displayed after migration#comment-12026231
benjifisher Q: Is this issue outdated?
benjifisher From reading the comments, I guess the steps to reproduce areInstall an unsupported version of Drupal from 2016 or 2017 or so.Have a source where taxonomy terms are missing hierarchy informationRun a migration.
quietone The fix was committed to 8.2.x
benjifisher If we add an update function now, then people who dealt with the problem by adding additional terns will all of a sudden have duplicates show up. That would be a problem.
quietone Good point.
quietone Only set the parent if the parent doesn't exist and the same term name doesn't exist?
benjifisher That will work most of the time. What if they fixed a typo in a term name? I do not think it is reliable enough.
benjifisher Is there some way we can provide this as an option, something that will not happen automatically as a database update?
quietone I don't know.
danflanagan8 Lurker here. Migrate was still experimental when that was committed, right?
danflanagan8 If so, does that change the approach?
benjifisher Good point. If it was still experimental, then we have less of a responsibility for fixing it.
quietone Drupal 8.6 sees migrate drupal and migrate drupal UI now are stable[#2735059]#comment-12721028Multilingual was later.
benjifisher In 8.2.0, it was alpha: https://www.drupal.org/project/drupal/releases/8.2.0 (2016-10-05) (edited)
benjifisher In 8.3.0, it was beta: https://www.drupal.org/project/drupal/releases/8.3.0 (2017-04-05) (edited)
benjifisher I think beta is when we promise an upgrade path. From the 8.2.0 release notes:The Drupal 7 to Drupal 8 migration is incomplete, but is suitable for developers who would like to help improve the migration, and can be used to test upgrades especially for simple Drupal 7 sites.
quietone An upgrade path will be provided from beta versions, but be aware it may contain critical bugs.https://www.drupal.org/about/core/policies/core-change-policies/experime...
danflanagan8 Seems pretty late then to worry about writing an upgrade path that was never promised.
benjifisher The fix was committed to 8.2.xIf it was fixed before 8.3.0 was released, then the migration system was still in alpha.For practical reasons, "pretty late" is a reasonable criterion. If we want people to trust us when we say that part of Drupal is promoted from alpha to beta, then we care more about the status at the time the bug was fixed.
benjifisher I think the Fixed issue is #2744639: Taxonomy term hierarchy migration incomplete (referenced in the summary of the issue we are discussing and marked as a related issue). The patch was committed to 8.1.x and 8.2.x on 2016-07-05, so that was before 8.2.0.Probably some people applied a patch from the issue and ran the update function. (I think some of the comments explicitly say so.)For both practical and reputational reasons, I think we can close this as outdated.

1️⃣1️⃣ Schedule the next maintainers-only meeting. (edited) 

benjifisher This will be a video meeting, for just the maintainers (probably). I think we agreed to have it instead of one of these weekly meetings, in today's time slot.
benjifisher When was the last one?
benjifisher @heddn, @mikelutz (he/him), @phenaproxima (he/him)
mikelutz (he/him) We should have recorded the last one, lol.
quietone Ah, mikelutz suggested the first NZ friendly meeting in April.
mikelutz (he/him) Yeah, I think we said April 8th.
mikelutz (he/him) Oh good, I just put in for vacation that week. :-)
mikelutz (he/him) But that's also the week before DrupalCon, so I think that's good.
quietone Ok, I'll add the date to the IS of the next meeting minutes
benjifisher It is settled, then. :+1:

1️⃣2️⃣ Wrap up

benjifisher Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.
quietone @benjifisher thank you

Participants:

benjifisher, dinarcon, quietone, anmolgoyal74, damienmckenna, jibran, gaurav mahlawat, heddn, Matroskeen, danflanagan8, mikelutz (he/him)

Comments

quietone created an issue. See original summary.

quietone credited DamienMcKenna.

quietone credited Gauravmahlawat.

quietone credited Matroskeen.

quietone credited anmolgoyal74.

quietone credited benjifisher.

quietone credited dinarcon.

quietone credited heddn.

quietone credited jibran.

quietone credited mikelutz.

quietone’s picture

quietone commented
Issue summary: View changes

quietone credited danflanagan8.

quietone’s picture

quietone commented
Status: Active » Needs review
quietone’s picture

quietone commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.