Given that this project is also maintained by the Solarium project maintainer, not going to dive into too much details, so keep it short :

CommentFileSizeAuthor
#4 3198150.patch1.07 KBmkalkbrenner
#2 3198150-2-curl-timeout.patch929 bytesDeFr

Comments

DeFr created an issue. See original summary.

DeFr’s picture

DeFr commented
Status: Active » Needs review
StatusFileSize
new 3198150-2-curl-timeout.patch929 bytes
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Needs work

You're right

+++ b/src/SolrConnector/SolrConnectorPluginBase.php
@@ -351,16 +351,14 @@ abstract class SolrConnectorPluginBase extends ConfigurablePluginBase implements
-    $configuration[self::QUERY_TIMEOUT] = $configuration['timeout'] ?? 5;

This line is important and must not be deleted

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3198150.patch1.07 KB
DeFr’s picture

DeFr commented
Status: Needs review » Reviewed & tested by the community

Thanks a lot for the quick response !

Patch looks sane ; hadn't realized what was up with the renaming, thanks for the @todo that clears that up. Moving to RTBC.

  • mkalkbrenner committed 9c0a2a9 on 4.x 
    Issue #3198150 by DeFr, mkalkbrenner: Curl adapter doesn't respect the...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.