Problem/Motivation

Space in mailto: href links to invalid HTML

Steps to reproduce

Add href mailto like: Test Email Fail
Test Email Success

Proposed resolution

Fixing the $mailtopattern Regular expression

CommentFileSizeAuthor
#2 fix-space-between-mailto-and-email-3198099-2.patch845 bytesjoshua1234511
screenshot-lwvcd7.sj-2021.02.12-11_39_28.png3.71 KBjoshua1234511

Issue fork spamspan-3198099

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joshua1234511 created an issue. See original summary.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
StatusFileSize
new fix-space-between-mailto-and-email-3198099-2.patch845 bytes

The issue is fixed by adjusted the regular expression $mailtopattern by handling the \s*

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Status: Active » Needs review
vitalie’s picture

vitalie commented

thanks @joshua1234511, this looks good. Could you add a test for this scenario in spamspan.test?

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented

joshua1234511 opened merge request !2

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Closed (works as designed)

A space after the mailto: is invalid markup.

joshua1234511 closed merge request !2