Problem/Motivation

When trying to create a new custom map. for example
screenshot create a new custom map

and after i save the configuration i get the message that The configuration options have been saved but the custom map not saved:
screenshot after config submit

Steps to reproduce

  1. Install the module and enable it
  2. Go to admin/config/system/leaflet-more-maps create a new custom map and check some layers
  3. Save configuration
CommentFileSizeAuthor
#2 leaflet_more_maps-fix-custom-maps-3198039-1.patch3.42 KBberramou
Screenshot 2021-02-11 at 21.13.41.png315.17 KBberramou
Screenshot 2021-02-11 at 21.09.43.png266.21 KBberramou

Comments

berramou created an issue. See original summary.

berramou’s picture

berramou commented
StatusFileSize
new leaflet_more_maps-fix-custom-maps-3198039-1.patch3.42 KB
poker.ca’s picture

poker.ca commented

Patch #2 fixed this issue for me when applied to version 2.1.0 - thank you!

  • RdeBoer committed 6b01d05 on 2.1.x authored by berramou 
    Issue #3198039 by berramou: Custom maps configuration broken
rdeboer’s picture

rdeboer
Location Melbourne
commented

Another nice patch. Thanks @berramou!

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Active » Fixed
berramou’s picture

berramou commented

Welcome @RdeBoer, i'm glad i could help :)
If you need help for maintain this module let me know!

rdeboer’s picture

rdeboer
Location Melbourne
commented

@berramou
I've made you co-maintainer.

berramou’s picture

berramou commented

Thank you @RdeBoer !

rdeboer’s picture

rdeboer
Location Melbourne
commented

@berramou -- no worries. Now next time you fix a bug for all of us, you don't have to wait a month before I see it and apply the patch!

berramou’s picture

berramou commented

Yeah sure, i guess we should create new release contain those fixed issues ?

berramou’s picture

berramou commented

@RdeBoer new release 2.1.1 with those fixes published!

berramou’s picture

berramou commented
Status: Fixed » Closed (fixed)
rdeboer’s picture

rdeboer
Location Melbourne
commented

@berramou Thank you!

ressa’s picture

ressa
he/him
commented

Where can I use a custom map and is it documented somewhere?

berramou’s picture

berramou commented

Hello @ressa, you can use custom maps in widget field, if you have for example field (field_geofield) of type geofield, if you have the Leaflet More Maps module installed, Go to manage display of your content / type or entity choose the Leaflet Map widget you will find your custom maps in the widget settings.

ressa’s picture

ressa
he/him
commented

Thanks for a fast reply @berramou! This is really strange, but all of a sudden I see my custom map under "Leaflet Map Tiles Layer". I tried everything, but it didn't show up, until now for some reason ... very odd. I cleared caches and everything, but maybe restarting DDEV was the missing piece of the puzzle. Anyway, it now works, and that's what counts.

It does seem like the custom maps switcher may conflict with the "Leaflet Demo page"? See #2819431-4: Document how custom maps and layer switcher works.