Problem/Motivation

Add a settings form because I think the exposed filters by default is annoying.
And also on an active website we need to manage audit log table size so it doesn't grow forever.

Proposed resolution

  • - Add settings form for modules settings
  • - Allow user to toggle if filters are expanded/collapsed by default
  • - Allow user to choose set limit to the log table similar to watchdog log to manage that tables growth overtime.
  • - Update module config to go to settings form instead of report

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release admin_audit_trail-1.0.6

User interface changes

screenshot of settings form

API changes

Data model changes

Release notes snippet

  • feat: #3197592 Added settings form to toggle filter expansion and limit audit log table size
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

NicholasS created an issue. See original summary.

nicholass’s picture

StatusFileSize
new6.43 KB

Sorry new patch, I had a '3' option I was using for testing cron which I don't think is likely anyone would really want.

nicholass’s picture

rajab natshah’s picture

Status: Active » Needs review
rajab natshah’s picture

Title: Add settings to limit database table size » Add settings to toggle between expanded/collapsed filters. And set an option to limit database table size
Version: 1.0.0-alpha1 » 1.0.x-dev
Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Thank you, Nice work Nicholas.
This is a must have feature.

The patch needs to be updated to latest 1.0.x-dev

rajab natshah’s picture

Status: Needs review » Needs work
rajab natshah’s picture

Issue summary: View changes

j-barnes made their first commit to this issue’s fork.

j-barnes’s picture

Status: Needs work » Needs review
StatusFileSize
new9.1 KB

@nicholass – Thanks for the patch! It's working great. I've rebased this and made a few minor updates, including dependency injection and some coding standard improvements. I'm also opening a merge request to get more eyes on it. Appreciate your work on this!

realityloop made their first commit to this issue’s fork.

rajab natshah’s picture

Title: Add settings to toggle between expanded/collapsed filters. And set an option to limit database table size » Add settings form to toggle filter expansion and limit audit log table size
rajab natshah’s picture

Assigned: Unassigned » s.halawani
Issue summary: View changes
Issue tags: +admin_audit_trail-1.0.5

rajab natshah’s picture

Assigned: s.halawani » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.