The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Core migration issues:
0️⃣ Who is here today? What do you know about PHP 8?
| benjifisher | Benji Fisher, one of the maintainers of the migration subsystem.I looked at the new features in PHP a few weeks ago, and the only one I remember is that we will be able to use named parameters when calling a function. So if foo() has three arguments, all optional, you can do something like$x = foo(arg2 = 17);(I do not remember the exact syntax) instead of$x = foo(NULL, NULL, 17);I think that will be nice. |
| damienmckenna | Damien. Nothing beyond possible performance improvements. |
| Matroskeen | Ivan, UA :sleeping:I know it’s faster and has some cool features like nullsafe operator (edited) |
| benjifisher | Oh, I remember another new feature:$obj?->propwill return $obj->prop if it exists; if not, it returns NULL instead of a warning or error. (Take what I say with a grain of salt.) |
| benjifisher | x-post |
| benjifisher | I am a little worried about some of the new rules for implicit type conversion. I prefer simple-to-state over what-you-expect. |
| quietone | Vicki, haven't read up on it yet |
| jibran | hi!, fn() => 0; (edited) |
| benjifisher | Please explain. |
| jibran | $fn1 = fn($x) => $x + $y;// equivalent to using $y by value:$fn2 = function ($x) use ($y) { return $x + $y;};I think I messed up the syntax above :D |
| benjifisher | You can edit your Slack posts.I have been annoyed for a long time that the keyword use is overloaded like this. If we have a simpler syntax and it avoids use, then that is a double win. |
| jibran | You can edit your Slack posts.I just wanted to live in shame of not knowing the correct syntax :stuck_out_tongue:I have been annoyed for a long time that the keyword use is overloaded like this.Hehe, use should only be used at the start of the file :smile: |
| gaurav mahlawat | Hi (Gauravmahlawat):wave: d.ohaven’t read up on it yet. (edited) |
| anmolgoyal74 | Hi, (anmolgoyal74)Union type hintspublic function testfunction(abc|xyz $input): int|float; |
1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
| quietone | 44 Postponed MNMI issues, which ones can we close? |
| benjifisher | Let's have a look! |
| quietone | #3084477: Bulk output entity count errors from migrate_drupal_ui tests |
| quietone | #2845340: migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups |
| quietone | Ah, I meant the two separate issues to be their own topic. They are not part of the postponed issues. (edited) |
| benjifisher | Right, I was confused. (edited) |
2️⃣ Action items. To be added later.
| benjifisher | #3084477: Bulk output entity count errors from migrate_drupal_ui tests (@benjifisher, @quietone) |
| benjifisher | NR: #2845340: migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups @mikelutz (he/him) |
| benjifisher | Comment on stale PMNMI issues: start the 3-month clock ticking. @benjifisher, @quietonehttps://www.drupal.org/project/issues/drupal?status=16&component=migration system&order=last_comment_timestamp&sort=asc |
| benjifisher | NR: #2579361: Row->setSourceProperty() docs are misleading. @benjifisher |
| benjifisher | #3063856: Add ability to view migrate_message table data. @quietone, @benjifisher |
| benjifisher | NW: #2687849: Add back rollbacks on migrate_drupal_ui. @quietone |
3️⃣ Statistics
| benjifisher | Fixed since last week's meeting: 9 (not counting the issue for the meeting). |
| benjifisher | RTBC: 2, one of shich is Major. Both were updated today! |
| benjifisher | NR: 34, including 4 Major and 1 that has not been updated in more than two months. |
| benjifisher | That is a lot of progress for one week. Someone has been busy, and it was not I! :clap: :clap: |
4️⃣ How can I help? Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...
5️⃣ Commerce Migrate
| benjifisher | Once I wrap up my current project at work, I am slated to start on a D7->D8 Commerce migration. This will be my first experience with the commerce_migrate module. Maybe I can help get it from RC to full release. |
| quietone | I would love the support to do that! |
| benjifisher | Is there a roadmap, or are there issues tagged that need to be fixed for a full release? |
| quietone | It is not up to date. the one thing that really should be done is remove/deprecate the dependency on commerce shipping. |
| Russell Clemings | FWIW, there's a patch and some other changes in #3119516: Order item not being linked to order that I had to use recently to get line items to be imported and linked to their orders. |
| benjifisher | @Russell Clemings: did you comment on the issue? If the patch worked for you, then that is the "T" part of RTBC.It looks as though Rob230 did not set the issue status to NR when posting a new patch. |
| benjifisher | It could also use an update to the issue summary. As it is now, someone has to read through the comments to get it to work. |
| quietone | @benjifisher this is what I though should be done to mark stable. #3067120: Mark Commerce Migrate stable |
| Russell Clemings | Yes, it's not exactly straightforward and the last patch didn't work for me. I need to study it a little more yet. |
6️⃣ DrupalCon Global etc.
| benjifisher | Are there any migration sessions or BoFs planned for DrupalCon Global? It is about 2 months away: April 12-16. |
| benjifisher | Or trainings? @dinarcon |
| benjifisher | Or other upcoming camps? |
| dinarcon | It seems there will be no trainings this week. I don't think submitted BoFs is available yet. |
| dinarcon | It looks like Florida Drupal Camp does not have migration related sessions. MidCamp will be in non-conference format. I guess anything would happen in situ I assume. |
| dinarcon | CFP still open for DrupalCon. I am planning to propose sessions including one about code/behind the scenes of the Migrate API. |
7️⃣ Bulk output entity count errors from migrate_drupal_ui tests (edited)
| quietone | A pet issue for me. It is a huge improvement for working with the entity count assertions in the Functional Upgrade tests. |
| benjifisher | #3084477: Bulk output entity count errors from migrate_drupal_ui tests |
| benjifisher | I must be more tired than I realize. I keep pasting in the wrong thing in the wron thread ... |
| benjifisher | If you had asked someone else to make the change, then you could review it.It does seem like a nice idea. |
| benjifisher | + // Assert the correct number of entities exist. Aggregate the failures to+ // to batch output all the feedback.It should be "the correct number ... exists."You have "to" at the end of one line and at the start of the next. |
| quietone | I'll fix that today. |
| benjifisher | - $mismatches[] = "Found $real_count $entity_type entities, expected $expected_count.";+ $mismatches[] = "Found $real_count $entity_type entities, expected $expected_count.\n"; } } $this->assertCount(0, $mismatches, implode(' ', $mismatches));Doesn't this create an extra newline at the end? If so, then use '\n' instead of ' ' in implode(). (edited) |
| benjifisher | ... and the whole patch is not much bigger than the interdiff. I can review that as soon as you update it. |
| benjifisher | I wrote '\n', but the updated patch has "\n": much better! |
8️⃣ migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups
| benjifisher | #2845340: migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups |
| quietone | This is ready for review. It has an update function and test (which may be a first for me). |
| quietone | Not sure how many projects this affects but it would be very good to remove the concern about migrate tables name clashing. |
| benjifisher | I will try to get to it soon. I have a few other Major issues that I have already reviewed once, and I want to prioritize those.@mikelutz (he/him), you reviewed an earlier version of this patch. Can you take a look? |
9️⃣ Close out old "Postponed MNMI" issues.
| quietone | I was thinking maybe anything last updated > 6 months is a strong candidate for closing. |
| benjifisher | https://www.drupal.org/project/issues/drupal?text=&status=16&priorities=...…]nent=migration%20system&order=last_comment_timestamp&sort=asc |
| benjifisher | A couple of them are assigned:#3187419: d7/NodeComplete source plugin adds invalid source "source_langcode" for "content_translation_source" destination property (@huzooka) |
| benjifisher | Let's start by assigning the issues to the person who created them, starting with the oldest. That should bump the issues. And give them a deadline: no response in 2 weeks, and we close them. |
| quietone | I was looking at the last bugsmash meeting where PMNMI was discusses. Over there, xjm suggested 3 months. https://drupal.slack.com/archives/C014QES6HSQ/p1612241299053800?thread_t... |
| quietone | Ah, I see that was when setting the status. |
| benjifisher | Let's stick to the 3-month standard. Any issue that we update today will reset the clock. I already look at Fixed, RTBC, NR issues at every meeting; I can add stale PMNMI issues to the list. |
Participants:
benjifisher, damienmckenna, Matroskeen, quietone, jibran, gaurav mahlawat, anmolgoyal74, Russell Clemings, dinarcon
Comments
Comment #8
quietone commentedComment #10
quietone commentedtodo:
Get d.o user name for Russell Clemings
Action items
Comment #12
quietone commentedComment #13
benjifisherComment #14
benjifisherI added some action items. Some are copied from last week's meeting. Others are from issues we discussed this week.
Comment #15
benjifisher