Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
| benjifisher |
Benji Fisher, one of the maintainers of the migration subsystem.I looked at the new features in PHP a few weeks ago, and the only one I remember is that we will be able to use named parameters when calling a function. So if foo() has three arguments, all optional, you can do something like$x = foo(arg2 = 17);(I do not remember the exact syntax) instead of$x = foo(NULL, NULL, 17);I think that will be nice. |
| damienmckenna |
Damien. Nothing beyond possible performance improvements. |
| Matroskeen |
Ivan, UA :sleeping:I know it’s faster and has some cool features like nullsafe operator (edited) |
| benjifisher |
Oh, I remember another new feature:$obj?->propwill return $obj->prop if it exists; if not, it returns NULL instead of a warning or error. (Take what I say with a grain of salt.) |
| benjifisher |
x-post |
| benjifisher |
I am a little worried about some of the new rules for implicit type conversion. I prefer simple-to-state over what-you-expect. |
| quietone |
Vicki, haven't read up on it yet |
| jibran |
hi!, fn() => 0; (edited) |
| benjifisher |
Please explain. |
| jibran |
$fn1 = fn($x) => $x + $y;// equivalent to using $y by value:$fn2 = function ($x) use ($y) { return $x + $y;};I think I messed up the syntax above :D |
| benjifisher |
You can edit your Slack posts.I have been annoyed for a long time that the keyword use is overloaded like this. If we have a simpler syntax and it avoids use, then that is a double win. |
| jibran |
You can edit your Slack posts.I just wanted to live in shame of not knowing the correct syntax :stuck_out_tongue:I have been annoyed for a long time that the keyword use is overloaded like this.Hehe, use should only be used at the start of the file :smile: |
| gaurav mahlawat |
Hi (Gauravmahlawat):wave: d.ohaven’t read up on it yet. (edited) |
| anmolgoyal74 |
Hi, (anmolgoyal74)Union type hintspublic function testfunction(abc|xyz $input): int|float; |
| benjifisher |
Once I wrap up my current project at work, I am slated to start on a D7->D8 Commerce migration. This will be my first experience with the commerce_migrate module. Maybe I can help get it from RC to full release. |
| quietone |
I would love the support to do that! |
| benjifisher |
Is there a roadmap, or are there issues tagged that need to be fixed for a full release? |
| quietone |
It is not up to date. the one thing that really should be done is remove/deprecate the dependency on commerce shipping. |
| Russell Clemings |
FWIW, there's a patch and some other changes in #3119516: Order item not being linked to order that I had to use recently to get line items to be imported and linked to their orders. |
| benjifisher |
@Russell Clemings: did you comment on the issue? If the patch worked for you, then that is the "T" part of RTBC.It looks as though Rob230 did not set the issue status to NR when posting a new patch. |
| benjifisher |
It could also use an update to the issue summary. As it is now, someone has to read through the comments to get it to work. |
| quietone |
@benjifisher this is what I though should be done to mark stable. #3067120: Mark Commerce Migrate stable |
| Russell Clemings |
Yes, it's not exactly straightforward and the last patch didn't work for me. I need to study it a little more yet. |
| quietone |
A pet issue for me. It is a huge improvement for working with the entity count assertions in the Functional Upgrade tests. |
| benjifisher |
#3084477: Bulk output entity count errors from migrate_drupal_ui tests |
| benjifisher |
I must be more tired than I realize. I keep pasting in the wrong thing in the wron thread ... |
| benjifisher |
If you had asked someone else to make the change, then you could review it.It does seem like a nice idea. |
| benjifisher |
+ // Assert the correct number of entities exist. Aggregate the failures to+ // to batch output all the feedback.It should be "the correct number ... exists."You have "to" at the end of one line and at the start of the next. |
| quietone |
I'll fix that today. |
| benjifisher |
- $mismatches[] = "Found $real_count $entity_type entities, expected $expected_count.";+ $mismatches[] = "Found $real_count $entity_type entities, expected $expected_count.\n"; } } $this->assertCount(0, $mismatches, implode(' ', $mismatches));Doesn't this create an extra newline at the end? If so, then use '\n' instead of ' ' in implode(). (edited) |
| benjifisher |
... and the whole patch is not much bigger than the interdiff. I can review that as soon as you update it. |
| benjifisher |
I wrote '\n', but the updated patch has "\n": much better! |
benjifisher, damienmckenna, Matroskeen, quietone, jibran, gaurav mahlawat, anmolgoyal74, Russell Clemings, dinarcon
Comments
Comment #8
quietone commentedComment #10
quietone commentedtodo:
Get d.o user name for Russell Clemings
Action items
Comment #12
quietone commentedComment #13
benjifisherComment #14
benjifisherI added some action items. Some are copied from last week's meeting. Others are from issues we discussed this week.
Comment #15
benjifisher