Problem/Motivation

Was reading through the EntityTypeInterface documentation and checked getHandlerClasses function needs to update some handler type names.

Steps to reproduce

Proposed resolution

Change `list` by `list_builder` and `render` by `view_builder`.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3196699-applied_patch.png119.61 KBabhijith s
#2 3196699-2.patch1.19 KBedysmp

Comments

edysmp created an issue. See original summary.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
StatusFileSize
new 3196699-2.patch1.19 KB

Here's the patch.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3196699-applied_patch.png119.61 KB

Applied patch #2 in 9.2.x.The list` is changed to `list_builder` and `render` is changed to `view_builder`after applying this patch.

after

RTBC +1

luiscarvalho’s picture

luiscarvalho commented
Status: Needs review » Reviewed & tested by the community

Reviewed patch #2 and it indeed fixed. I'm moving to RTBC.

  • catch committed 5d5bc96 on 9.2.x 
    Issue #3196699 by edysmp: Set the proper handler type names on...

  • catch committed bfa10df on 9.1.x 
    Issue #3196699 by edysmp: Set the proper handler type names on...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

@Abhijith S there's no need to upload a screenshot of the patch applying, because DrupalCI already checks that for us. The screenshot actually means it takes longer for other people to review the issue. In this case all we needed for a review of the patch was to confirm that the list_builder and view_builder handler types were actually correct.

Committed 5d5bc96 and pushed to 9.2.x, cherry-picked to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.