This is a service which is used for sending SMS messages via a third-party service.

Project link

https://www.drupal.org/project/smssystem

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/smssystem.git

Comments

andrei.vesterli created an issue. See original summary.

avpaderno’s picture

Priority: Critical » Normal
Issue summary: View changes
Issue tags: +PAreview: project created less than ten days ago
andrei.vesterli’s picture

Issue summary: View changes

kiamlaluno credited adevms.

avpaderno’s picture

I am crediting a user who participated in the duplicate application.

klausi’s picture

Status: Needs review » Fixed

manual review:

  1. The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722
  2. There are 2 git branches: 8.x-1.x and 1.0.x which is confusing. I would recommend to use a git branch "1.x" in the future that matches your releases for version 1.
  3. info file: some dependency namespaces are wrong like "drupal:views_data_export". This module does not exist in drupal core. Did you mean https://www.drupal.org/project/views_data_export ? Then it should be "views_data_export:views_data_export".
  4. The module file is empty, it can be removed.
  5. config schema is missing, see https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-...

Otherwise looks good to me.

Thanks for your contribution, Andrei!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dan.golovatic’s picture

Hello @apaderno, @klausi ,

Can you reopen this application, please?

andrei.vesterli’s picture

Issue summary: View changes