Problem/Motivation

We are supporting adding of Bootstrap btn and similar CSS classes like btn-primary... to site main menu. But we can improve this a bit. By default, we are centring first level menu items vertically but we are not doing this in the case when a menu item is a button. Also, we have some hardcoded rules for off-canvas navigation for the button components, this we should make more flexible.

CommentFileSizeAuthor
#6 improve-navbar-menu-items-as-buttons-3196202-6.patch3.86 KBpivica
#5 improve-navbar-menu-items-as-buttons-3196202-4.patch3.9 KBpivica
#4 improve-navbar-menu-items-as-buttons-3196202-4.patch699 bytespivica
#4 interdiff-3196202-2-4.txt699 bytespivica
#2 improve-navbar-menu-items-as-buttons-3196202-2.patch4.05 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new improve-navbar-menu-items-as-buttons-3196202-2.patch4.05 KB

Here is a first patch.

pivica’s picture

pivica commented

Note to my self: DO NOT merge this into next release alpha10, we should first test this a bit against client projects.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3196202-2-4.txt699 bytes
new improve-navbar-menu-items-as-buttons-3196202-4.patch699 bytes

Some changes for other patch #3196636: Remove navbar nav-link horizontal padding creep into this one, fixed that.

pivica’s picture

pivica commented
StatusFileSize
new improve-navbar-menu-items-as-buttons-3196202-4.patch3.9 KB

The last patch is wrong, here is a correct one.

pivica’s picture

pivica commented
StatusFileSize
new improve-navbar-menu-items-as-buttons-3196202-6.patch3.86 KB

Updated patch against latest dev.

  • pivica committed cd7b900 on 8.x-1.x 
    Issue #3196202 by pivica: Improve buttons support in main navbar menu
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.