Steps to reproduce:
Install devel module.
Open URL like /node/10832/devel/token.
A lot of notices for different tokens: https://take.ms/p87rH.

CommentFileSizeAuthor
#7 metatag-n3196067-7.patch917 bytesdamienmckenna
#7 metatag-n3196067-7.interdiff.txt966 bytesdamienmckenna
#6 metatag-n3196067-6.patch966 bytesdamienmckenna
#5 3196067-5.patch673 bytesmohit.bansal623

Issue fork metatag-3196067

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ruslan Piskarov created an issue. See original summary.

Ruslan Piskarov opened merge request !10

Ruslan Piskarov opened merge request !11

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

It might be better to check if $processed_tags[$tag_name][$delta] exists.

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3196067-5.patch673 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3196067-6.patch966 bytes

Yay PHP 7's null coalescing operator.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3196067-7.interdiff.txt966 bytes
new metatag-n3196067-7.patch917 bytes

One of these days I'll learn how to make a patch properly ;-)

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented
Status: Needs review » Reviewed & tested by the community

Thank you, @DamienMcKenna.
Looks good to me.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Notice: Undefined offset: 2 in metatag_tokens() (line 218 of modules\contrib\metatag\metatag.tokens.inc) » Notice: Undefined offset: 2 in metatag_tokens() (line 218 of metatag.tokens.inc)
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3186720: Plan for Metatag 8.x-1.16

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.