Problem/Motivation

There's no reason for our settings to be prefixed by commerce_file_enable_download_limit, since the config object is already commerce_file.settings.

Let's rename "commerce_file_enable_download_limit" to "enable_download_limit" and "commerce_file_download_limit" to just "download_limit".

Now that we're introducing download limits per variations, I'm actually wondering whether we should get rid of the global settings.

I'm afraid that having both will create confusions... For example, how do you actually set an unlimited download limit for a given variation if a global limit is configured?

Should you set the limit to 0?

Since the module doesn't have a stable release, we can probably go ahead and rename the settings for now although it probably doesn't hurt to write a quick update to migrate to the new settings keys.

CommentFileSizeAuthor
#2 3196038-2.patch6.52 KBmohit.bansal623

Comments

jsacksick created an issue. See original summary.

mohit.bansal623’s picture

Status: Active » Needs review
StatusFileSize
new6.52 KB

Replaced all words as expected.

jsacksick’s picture

Issue tags: +beta blocker

jsacksick’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.