Needs review
Project:
Leaflet Layers
Version:
1.1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2021 at 03:57 UTC
Updated:
5 Apr 2025 at 10:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andeersg commentedHi,
Is the description on the module page not enough? Or would you like more descriptions on the different pages?
Comment #3
DaMa commentedHello andeersg,
would be nice to have an example of what one can achieve when using this module.
Comment #4
andeersg commentedThat is the description from the module page, do you think it's clear enough? Would it help if that is added to
hook_help?Comment #5
gerhard1176 commentedThis module looks promising, but I too miss some documentation. It would be nice to see a use case on how you create an overlay layer of Geofield points and put it into the Map bundle - without making use of Javascript. I have tried to set up a map bundle with a couple of overlays - the base layer shows up fine, the overlays are empty. I am also puzzled by the fact that the layer switcher shows radio-buttons instead of check-boxes for the overlay layers.
Comment #6
andeersg commentedgerhard1176: This module ony provides data to leaflet module, if you have issues with the actual map and/or content of a layer then it would be better to create an issue in leaflet.
If a layer is working when added through the hook, but not through this module, then create an issue here and I can take a look.
Comment #7
DaMa commented@andeersg Does this module solve my question https://www.drupal.org/project/geolocation/issues/3165760 ?
What confuses me is that you write about different modules. Do we need different modules, or can this also be different sources, e.g. geolocation gmx data from two different nodes?
Comment #8
andeersg commented@DaMa: This module adds functionality to the Drupal Leaflet module, with this module you can add multiple layers which will be available in your map without knowing how to create a module and define layers in code.
This module will not work with the Geolocation module.
This module does not have any map functionality in it self, it has a dependency on Leaflet module. It provides an admin interface to manage and add extra layers through UI instead of code.
Comment #9
chucksimply commentedI have to say, i'm also slightly unclear on it's exact use. A tutorial or real-world use case example would be extremely helpful. Thanks for the work on this module though!
Comment #10
andeersg commentedChuckSimply:
Do you feel this explanation is lacking something? What could be added to make it more clear?
Comment #11
chucksimply commentedMaybe something like this...?
Combine multiple map layers for a single Leaflet map directly through the Drupal UI.
Why?
By default, Leaflet allows you to display one map layer at a time. Leaflet Layers allows you to combine multiple map layers (i.e OpenStreetMap and Google Satellite) into a single map bundle, so users can toggle between these map layers when viewing a single leaflet map.
How to use
Comment #12
_kom__ commented... or you can add your own layer on "Map Layer" admin page. All you have to do is add URL template and some attribution. A lot of nice examples are given there: https://leaflet-extras.github.io/leaflet-providers/preview/. Just copy red-marked variables from Plain Javascript window to fields on "Map Layer" page and enjoy!
Comment #13
andeersg commentedComment #14
ressaI agree, the description is a bit too general. Everyone here probably knows how Geofield and Leaflet work together, but not quite how this module fits in ...
For example, it would be great if the README included a list of the minimal steps required to display two layers in a View with Leaflet. This would help new users understand the concept much better.
Comment #17
orkutmuratyilmazHello all,
I've created a Merge Request for this issue and I hope that it works.
Best,
Orkut
Comment #18
orkutmuratyilmazI'm also changing the issue's status as "Needs review".
Comment #21
orkutmuratyilmazSorry for too much notifications.
I realize that, I did my commit and MR to 1.1.x branch of the project. So I'm changing issue's version too.
Comment #22
orkutmuratyilmazAny comments for the patch?
Comment #23
ressaYour detailed instructions made it easy to get it working. Thanks @Orkut Murat Yılmaz!
I would suggest to maybe add this sentence, at the end on the project description. Now:
... expand it to this?
Also, perhaps these two images could replace the current image, to better showcase the possibilities?
Form
Map
Comment #24
ressaComment #25
orkutmuratyilmaz@ressa, thanks for your beautiful review. I've added your lines to another commit and it is a part of the first MR now.
I wish that the maintainers of this nice module would add those images to project node too.
Now I'm changing issue's status as needs review again.
Comment #26
ressaPerfect @Orkut Murat Yılmaz, thanks! I have updated the issue summary, adding more details in the README, and updating the images as separate tasks.
Comment #28
azin89 commented@ressa Hi, I am trying to repost my question again. So, I have installed all the necessary modules to run Leaflet Layers, and it seems that everything works well. I have made new Map bundles, and new a Content Type, however, the problem is that it seems for each new map, I need to make a new content type, and in the Display options connect it to the relevant Map bundle, which doesn't seem to be right.
Unfortunately, the example here, and elsewhere stop just before mentioning how we could in practice make a new node/view that shows a map bundle.
Thanks.
Comment #29
ressaGreat, I now see it!
Perhaps someone following this issue has the answer, so that the steps can be added in the README and in the doc page at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...
Comment #30
orkutmuratyilmaz@andeersg, any chance for reviewing this issue too?