Problem/Motivation

  • When a crisis banner/notification banner is unpublished it is not shown in the crisis dashboard.
  • When a crisis banner is unpublished, on the front-end a message is displayed.

Steps to reproduce

  • enable a crisis banner in the crisis dashboard
  • unpublish the crisis banner
  • the banner is still active, but it is not shown as the selected banner in the dashboard, a message is displayed on the front-end

Proposed resolution

- Show the banner in the dashboard, with notification "Not published'.
- Add check for published state

CommentFileSizeAuthor
#3 dvg-crisis_dashboard_unpublished_node-3194900-3.patch3.71 KBjoshahubbers
#2 dvg-crisis_dashboard_unpublished_node-3194900-2.patch3.05 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg-crisis_dashboard_unpublished_node-3194900-2.patch3.05 KB

This patch changes the function _dvg_crisis_dashboard_get_nodes to include the unpublished node (only the selected unpublished node, not all unpublished nodes), with the text "Not published" appended to the title.
When the node is deleted, an option with the text "Node has been deleted" is added.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg-crisis_dashboard_unpublished_node-3194900-3.patch3.71 KB

New patch

  • This patch changes the function _dvg_crisis_dashboard_get_nodes to include the unpublished node (only the selected unpublished node, not all unpublished nodes), with the text "Not published" appended to the title.
  • When the node is deleted, an option with the text "Node has been deleted" is added.
  • When the node is not published, it will not be displayed as a banner.
joshahubbers’s picture

joshahubbers commented
Title: When a crisis banner/notification banner is unpublished it is not shown in the crisis dashbaord » Crisisbanner visibility issues
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
Status: Active » Needs review
tvoesenek’s picture

tvoesenek commented
Status: Needs review » Reviewed & tested by the community

Patch looks good to me!

tvoesenek’s picture

tvoesenek commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.