Hi,
CivicActions is reviewing and upgrading modules for use on client sites. Part of that process is an internationalization review. Attached is a patch for the problems found. They mainly fall within two categories: (a) messages passed to drupal_set_message() should have t() called on them (b) strings passed to t() should not contain leading or trailing spaces as it can cause problems for the translators.
I also included a couple of other changes. Hope it helps.
Cheers,
Stella
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | friendlist_codereview.patch | 5.1 KB | stella |
| friendlist_codereview.patch | 5.1 KB | stella |
Comments
Comment #1
stella commentedUpdated patch - with corrected whitespace
Comment #2
catchAll these changes are good, and the patch applies cleanly.
Comment #3
mariusooms commentedAgreed. I'd commit it, but my Drupal account is broken. We'll wait for mercmobily.
Regards,
Marius
Comment #4
mercmobily commentedHi,
What can I say?
You guys really know Drupal. I didn't even know menu_get_object('node') was there and it was so _damn_ useful. I am gonna have to work on all of my modules for this...
Patch applied with apologies for the silly mistakes.
Do you guys think the module is ready for release? It hasn't had any major changes in a while now.
Merc.
Comment #5
mercmobily commentedHi,
(And a big "thank you")
Merc.
Comment #6
mariusooms commentedThere are two more issues in the queue that need attention before a 1.0 release, imho.
http://drupal.org/node/319787
http://drupal.org/node/319808
Regards,
Marius
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.