Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#9 domain_language.8.x-1.0-alpha2-Drupal9.patch322 bytesroy84
#7 3194703-7.patch370 bytesrav98

Issue fork domain_language-3194703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rav98 created an issue. See original summary.

rav98 opened merge request !1

rav98 closed merge request !1

rav98 opened merge request !2

rav98’s picture

rav98 commented

Sorry for multiple merge requests, first was broken and I closed it.
Now I use my commit in my project because I need to update it at Drupal 9. Please let me know when you approve my request.
Thanks!

rav98’s picture

rav98 commented
Status: Active » Needs review
rav98’s picture

rav98 commented
StatusFileSize
new 3194703-7.patch370 bytes

Also, I created a patch for Drupal 9 Compatibility.

dimr’s picture

dimr commented
Status: Needs review » Needs work

This issue is duplicated with #3140251:Automated Drupal Rector fixes
Not sure who should/can close the issue as duplicated.

roy84’s picture

roy84 commented
StatusFileSize
new domain_language.8.x-1.0-alpha2-Drupal9.patch322 bytes

Tried a lot of patches placed here, and in #3140251:Automated Drupal Rector fixes, and none of them work.

I think they fail because the Drupal packaging system changed the following line in the info.yml file:

core: 8.x
into:
# core: 8.x

And to add the core version later on in the file:

# Information added by Drupal.org packaging script on 2018-10-18
version: '8.x-1.0-alpha2'
core: '8.x'
project: 'domain_language'
datestamp: 1539846186

Changes are "diffed" against the repository WITHOUT the # before the core version in the info file. And composer has download an info.yml file WITH the # before the core version resulting in a failed patch because of a mismatch in that line.

I've placed the "core_version_requirement: ^8 || ^9" a few lines higher, so the "core: 8.x" line does not need to be present in the patch file.

Problem solved.

roy84’s picture

roy84 commented
Status: Needs work » Needs review
mistrae’s picture

mistrae commented
Status: Needs review » Reviewed & tested by the community

Mistrae opened merge request !3

cslevy’s picture

cslevy commented

Can somebody release the D9 version of the module?

justclint’s picture

justclint commented

I was able to successfully apply this patch while on drupal 8. But now that im trying to upgrade to Drupal 9 it seems like the patch doesnt get applied in time so composer keeps failing with:

Problem 1
    - Root composer.json requires drupal/domain_language 1.0.0-alpha2 -> satisfiable by drupal/domain_language[1.0.0-alpha2].
    - drupal/domain_language 1.0.0-alpha2 requires drupal/core ^8 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but it conflicts with your root composer.json require (9.2.7).

Can we please get this fix merged in. EOL for D8 is Nov. 2, 2021.

cslevy’s picture

cslevy commented

Yes. This is the main issue. The module need to be released for D9. Otherwise you cannot install it with composer on D9. There is a workaround, to define the package in your composer.json file, and overwrite the require part with D8 || D9 requirement

"require": {
"drupal/core": "^8 || ^9.0"
}

Like this.

But doesn't work always.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

We have made the 2.0.x-dev release compatible with Drupal 9. applied the above patch as well.

use composer require 'drupal/domain_language:2.0.x-dev@dev'

A new stable release to follow shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.