Problem/Motivation

So here is a series of patches that fixes the following problems for Mapbox integration (to make it work with my project):
- autocomplete suggestion are now filtered by the country selected by the user => untested without country selection !!
- postcode and cites are wrongly filled in my case => patch should improve robustness across address types
- compatibility with PHP 7.2

I am sorry I did not create 3 separate issues, but I don't have the time to make separate patches, hope this help !

CommentFileSizeAuthor
#4 adress_mapbox_autosuggestion.patch5.13 KBlazzyvn
#2 address_mapbox_full_autocomple.patch5.11 KBthony
php_72_compatibility.patch560 bytesthony
fix_adress_autocomplete_3.patch1.26 KBthony
fix_adresse_autocomplete_2.patch774 bytesthony
fix_address_autocomple.patch2.14 KBthony

Issue fork address_autocomplete-3194599

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    1 hidden branch
  • 1.0.x Comparechanges, plain diff MR !1
About issue forks

Comments

Thony created an issue. See original summary.

thony’s picture

thony commented
StatusFileSize
new address_mapbox_full_autocomple.patch5.11 KB
thony’s picture

thony commented

(Handling of administrative areas for certain countries, patch merge in a single file)

lazzyvn’s picture

lazzyvn commented
StatusFileSize
new adress_mapbox_autosuggestion.patch5.13 KB

Hello
@Thony I don't think your patch is good enough you modify with your project personal
exemple:

if(isset($values["shipping_information"]["shipping_profile"]["address"][0]["address"]["country_code"])){

or administrative area is not always present in some countries

I make quick Patch it fix some bug for mapbox. Some countries have format adresse lik [Street number] [Street name]

lazzyvn opened merge request !1

dejan0’s picture

dejan0 commented

Thanks, @Thony, and @lazzyvn, good catches! I will check/test solutions, and include them in the next release!

socialnicheguru’s picture

socialnicheguru commented
Status: Active » Needs review

  • granik committed f18c71f on 1.0.x 
    Issue #3194599: mapbox integration improvements
granik’s picture

granik
he/him
Location Vienna
commented
Status: Needs review » Fixed

Committed #4. Thanks @ lazzyvn.

granik closed merge request !1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.