Problem/Motivation

See https://www.drupal.org/node/3104677

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 interdiff.txt907 bytesPooja Ganjage
#7 3194270-7.patch7.02 KBPooja Ganjage
#2 3194270.patch6.13 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new 3194270.patch6.13 KB

100% straight port us CR. Pretty simple.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Manual testing, things worked fine after clearing cache. So, maybe this needs an empty update hook to flush cache?

Status: Needs review » Needs work

The last submitted patch, 2: 3194270.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Illinois
commented

I guess we also might need to adjust version ranges in .info.yml or composer.json that this requires 9.0.0+

maximpodorov’s picture

maximpodorov commented

Drupal 8.9 has js-cookie, so this patch can be used with Drupal 8.9.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3194270-7.patch7.02 KB

Hi,

Creating a patch as suggested in #5 comment.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Illinois
commented

Any chance for an interdiff?

Status: Needs review » Needs work

The last submitted patch, 7: 3194270-7.patch, failed testing. View results

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new interdiff.txt907 bytes

Attached interdiff.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
svenryen’s picture

svenryen commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch!

  • svenryen committed aaabcac on 8.x-1.x 
    Issue #3194270 by Pooja Ganjage, heddn, maximpodorov, svenryen: The core...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.