I just found an extra semi-colon on -
https://git.drupalcode.org/project/geofield_map/-/blob/8.x-2.x/js/geofie...

CommentFileSizeAuthor
#4 geofield_map-3193676-4.patch989 bytesdimaro
#2 3193676-2.patch975 bytesmohit.bansal623

Issue fork geofield_map-3193676

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

devitate created an issue. See original summary.

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3193676-2.patch975 bytes

I found 2 semicolons one in js file and other in php file. Corrected and created the patch. Please review.

itamair’s picture

itamair commented
Status: Needs review » Reviewed & tested by the community

Nice!

dimaro’s picture

dimaro commented
Version: 8.x-2.67 » 3.0.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new geofield_map-3193676-4.patch989 bytes

Hey @itamair,

I have recently been checking the issue queue for this module due to everything that happened with the polyfill.io library (thanks for your quick intervention) and I saw this issue on RTBC for over 3 years. Is there any reason why this task was not merged at the time? In fact, I have seen that the patch was developed for the 2.x branch and now we are on the 3.x branch. So, I have created a new patch that applies to the current development branch since both semicolons continue in the code base.

dimaro opened merge request !18

  • itamair committed f1b52346 on 3.0.x 
    Issue #3193676 by dimaro, mohit.bansal623, devitate: 2 semi colon in js
itamair’s picture

itamair commented
Status: Needs review » Fixed

Thanks @dimaro!
probably, this was so trivial that simply wen out of my radar.

Committed into 3.0.x, will be part of the next module release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

itamair closed merge request !18